http-add-on with istio #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wozniakjan
force-pushed
the
http-add-on_with_istio
branch
from
e7d81cf to
40ca37b
Compare
wozniakjan
commented
Jun 20, 2024
|
|
||
| Let's expose it using istio `VirtualService`. | ||
| ``` | ||
| $ kubectl apply -f https://raw.githubusercontent.com/kedify/examples/main/samples/http-add-on_with_istio/manifests/istio.yaml |
There was a problem hiding this comment.
not yet available on that link until this PR merges, for now available under
https://raw.githubusercontent.com/wozniakjan/kedify-examples/http-add-on_with_istio/samples/http-add-on_with_istio/manifests/istio.yaml
26534d3 to
6a29e34
Compare
Signed-off-by: Jan Wozniak <[email protected]>
wozniakjan
force-pushed
the
http-add-on_with_istio
branch
from
6a29e34 to
53bbd8b
Compare
zroubalik
reviewed
Jun 21, 2024
|
|
||
| ##### Step 4: Start autoscaling | ||
|
|
||
| First we will need to create `HTTPScaledObject` to tell KEDA and http-add-on what metrics to use and which `Deployment` to scale |
There was a problem hiding this comment.
Once we have the build with kedify-http scaler, let's start using ScaledObject in favor of HTTPScaledObject
There was a problem hiding this comment.
I noticed the examples in this repo all use upstream KEDA and are without Kedify agent, so I followed that pattern too.
I will make sure to list Kedify agent as a prerequisite and reference this:
https://kedify.io/resources/blog/kedify-keda-powered-public-beta-launch-announcement
There was a problem hiding this comment.
Yeah, from now go on, we should use the Kedify approach, also in the examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a guide on how to use upstream KEDA and http-add-on together with istio.