enable aws iam rds auth for the postgres scaler #6449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add iam auth for postgres
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
pkg/scalers/postgresql_scaler.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| DBendpoint := fmt.Sprintf("%s:%s", meta.Host, meta.Port) |
There was a problem hiding this comment.
use net.JoinHostPort instead of fmt.Sprintf(meta.Port, meta.Host)
🧹 Fixed in commit d00a759 🧹
haydn-j-evans
force-pushed
the
feature/add-iam-auth-for-postgres-rds
branch
from
d00a759 to
b205e5f
Compare
haydn-j-evans
force-pushed
the
feature/add-iam-auth-for-postgres-rds
branch
from
b205e5f to
fce9192
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add iam auth for postgres
Provide a description of what has been changed
Checklist
Fixes #
Relates to #