Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy 404s #708

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 10, 2022

  • Contributes to Top 404s as of 2022/03/04 #692 for the deploy path
  • This is the resulting diff in the generated _redirects file, when we ignore changes in whitespace:
    $ (cd public && git diff -bw --ignore-blank-lines)
    diff --git a/_redirects b/_redirects
    index 5d40ff6..07b3c0a 100644
    --- a/_redirects
    +++ b/_redirects
    @@ -11,5 +11,5 @@
     /docs/operate/*                 /docs/2.6/operate/:splat
     /concepts                       /docs/2.6/concepts     301!
     /docs/concepts/*                /docs/2.6/concepts/:splat
    -/deploy     /docs/2.6deploy     301!
    +/deploy                         /docs/2.6/deploy     301!
     /docs/deploy/*                  /docs/2.6/deploy/:splat
    Note the added /.

Redirect test:

@netlify
Copy link

netlify bot commented Mar 10, 2022

✅ Deploy Preview for keda ready!

🔨 Explore the source changes: 9de0419

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/6239bd65b5ead700086fe2af

😎 Browse the preview: https://deploy-preview-708--keda.netlify.app

@chalin chalin force-pushed the chalin-fix-deploy-404-2022-03-10 branch from 205f311 to 5c9fe02 Compare March 10, 2022 14:23
@chalin chalin mentioned this pull request Mar 10, 2022
10 tasks
chalin and others added 2 commits March 22, 2022 12:12
Signed-off-by: Patrice Chalin <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Patrice Chalin <[email protected]>
@chalin chalin force-pushed the chalin-fix-deploy-404-2022-03-10 branch from eed576b to 9de0419 Compare March 22, 2022 12:13
@chalin
Copy link
Contributor Author

chalin commented Mar 22, 2022

@JorTurFer @tomkerkhove - This is ready for final review and merge. Thanks.

@zroubalik zroubalik merged commit 7550dc0 into kedacore:main Mar 22, 2022
@chalin chalin deleted the chalin-fix-deploy-404-2022-03-10 branch March 22, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants