DMD-33 snowflake definitions directly from SchemaReflection #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtabiberle
force-pushed
the
vb-DMD-33-bucket-refresh
branch
2 times, most recently
from
a240706 to
c408d87
Compare
vojtabiberle
force-pushed
the
vb-DMD-33-bucket-refresh
branch
from
c408d87 to
afa34a1
Compare
vojtabiberle
force-pushed
the
vb-DMD-33-bucket-refresh
branch
from
2f6327f to
953cd8b
Compare
This reverts commit 953cd8b.
vojtabiberle
force-pushed
the
vb-DMD-33-bucket-refresh
branch
from
b208341 to
1ac332a
Compare
vojtabiberle
force-pushed
the
vb-DMD-33-bucket-refresh
branch
from
1ac332a to
168db75
Compare
jirkasemmler
approved these changes
Jan 20, 2025
| { | ||
| $informationsQuery = sprintf( | ||
| 'SELECT TABLE_NAME, TABLE_TYPE, BYTES, ROW_COUNT '. | ||
| 'FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = \'%s\' ORDER BY TABLE_NAME;', |
There was a problem hiding this comment.
tohle by se melo escapovat jako SnowflakeQuote::quote($this->schemaName), nemusel bys pak mit \'%s\'
udelej to pls jeste takto, at to tady je jednotne
There was a problem hiding this comment.
pravda, upraveno
Jako já vím, ale musel jsem se nějak držet té struktury, kterou tam už máme, aby to bylo vlastně zaměnitelné v connection a všude jinde. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://keboola.atlassian.net/browse/DMD-33
Connection PR: https://github.com/keboola/connection/pull/5415
SAPI PR: keboola/storage-api-php-client#1439
Changes:
SnowflakeSchemaReflection can directly return whole schema definition and uses less queries