CT-1169 add parsing of precision&scale to SNFLK #127
Conversation
tomasfejfar
force-pushed
the
CT-1169-put-column-definition-endpoint
branch
from
0c4ad36 to
5e17c4d
Compare
tomasfejfar
force-pushed
the
CT-1169-put-column-definition-endpoint
branch
2 times, most recently
from
36a2a6a to
daaae47
Compare
| $parsed = array_map(intval(...), explode(',', $this->getLength())); | ||
| return ['numeric_precision' => $parsed[0], 'numeric_scale' => $parsed[1]]; | ||
| } | ||
| return ['character_maximum' => $this->getLength()]; |
There was a problem hiding this comment.
hmm co když si nadefinuju NUMERIC(10) bez precision? Opraví to v konstruktoru? Failne to v konstruktoru? Nebo to failne tady? Vlastně nevím :D
There was a problem hiding this comment.
je škoda žes k tomu není DTO ale dělá to array.
There was a problem hiding this comment.
Good point, doplním do testu
There was a problem hiding this comment.
Undefined array key 1
/var/www/html/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php:132
/var/www/html/vendor/keboola/php-datatypes/src/Definition/Snowflake.php:213
/var/www/html/vendor/keboola/php-datatypes/tests/SnowflakeDatatypeTest.php:393
🙈
There was a problem hiding this comment.
SNFLK to interně přeloží na NUMBER(10,0), ale to se sem nepropíše :(
There was a problem hiding this comment.
jestli to padá tady tak bych tam přidal 0 asi, otázka jaký to má case reálný pak. Jestli to može propadnůt ze SNFLK nebo ze Storage Api
There was a problem hiding this comment.
Ze SNFLK ne. Tam když pošleš něco nekompletního, tak to vrací kompletní.
NUMBER(10) → NUMBER(10,0)
NUMBER → NUMBER(38,0)
Ze SAPI asi jo, pokud někde nastavujeme tyhle hodnoty z requestu a ne z backendu.
There was a problem hiding this comment.
Vyřšeno v 87bae6c
There was a problem hiding this comment.
imho přes api by to přešlo tam sa spoléhá na validaci z tady toho Snowflake objektu
packages/php-table-backend-utils/src/Table/Snowflake/SnowflakeTableQueryBuilder.php
Show resolved
Hide resolved
| /** | ||
| * @return \Generator<string, array{Snowflake,Snowflake,string}> | ||
| */ | ||
| public function provideGetColumnDefinitionUpdate(): Generator |
There was a problem hiding this comment.
Chybý mě test co dělá víc věcí naráz
There was a problem hiding this comment.
Vyřešeno v 15a44a4
tomasfejfar
force-pushed
the
CT-1169-put-column-definition-endpoint
branch
from
15a44a4 to
f74d392
Compare
tomasfejfar
force-pushed
the
CT-1169-put-column-definition-endpoint
branch
from
f74d392 to
f3b83ba
Compare
Jira: CT-1169
Connection PR: https://github.com/keboola/connection/pull/4838
SAPI PR: keboola/storage-api-php-client#1264