BIG-203 Convert types not supported in BQ REST API #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes in BQ REST API
| // Map of types available in SQL api but not supported by REST API | ||
| // Most of them are aliases for other types | ||
| public const REST_API_TYPES_MAP = [ | ||
| self::TYPE_INT => self::TYPE_INT64, |
There was a problem hiding this comment.
Ok, ale co ARRAY a INTERVAL ?
myslim, ze oba tyto typy nemame dobre uchopene v connection. array by mel prijit s definici a interval taky. Imho bychom to meli zakazat na request objectu. Toto bych ale shipnul a na ten array a interval zalozil dalsi task
There was a problem hiding this comment.
array je repeated record a interval nemá dokumentaci pro REST API ani, takže sem ho zatím přeskočil
There was a problem hiding this comment.
jo, ale kdyz to sem dorazi, tak to nekde nejak neplanovane vyhuci. Takze bychom to meli imho odchytit uz nekde v connection. Takze to bude chtit nejakou dalsi praci
There was a problem hiding this comment.
jirkasemmler
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIG-203