uv 💜 #4
Open
uv 💜 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.10 is currently the latest version in the base image, this shall be fixed later on 🤞
use just a single python env so that all image packages, this component's packages and user packages can be imported flawlessly
There was a problem hiding this comment.
PR Overview
This PR introduces configuration and execution changes to incorporate the "uv" command for running lint and test processes, as well as updating project dependency configurations and docker environment variable settings.
- Add new project configuration (pyproject.toml).
- Update GitHub Actions workflow to use "uv run --active" for linting and testing.
- Adjust docker-compose environment variable and update component code formatting and package installation commands.
Reviewed Changes
| File | Description |
|---|---|
| pyproject.toml | Introduces project metadata and dependencies |
| .github/workflows/push.yml | Modifies docker run commands to use "uv run --active" |
| docker-compose.yml | Updates environment variable for data directory |
| src/component.py | Refactors string quoting, logging messages, and changes package installation to use "uv pip install" |
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/component.py:98
- The package installation command now uses 'uv pip install'. Ensure that the 'uv' command is available in all target environments, or provide a fallback to the standard pip invocation if not.
"uv",
| @@ -40,41 +42,40 @@ def run(self): | |||
| parameters = self.configuration.parameters | |||
|
|
|||
| self._set_init_logging_handler() | |||
| script_path = os.path.join(self.data_folder_path, 'script.py') | |||
| logging.info(sys.executable) | |||
There was a problem hiding this comment.
The logging of sys.executable appears to be a leftover debug statement; consider removing it or wrapping it in a conditional to avoid unintended output in production.
Suggested change
| logging.info(sys.executable) | |
| if logging.getLogger().getEffectiveLevel() == logging.DEBUG: | |
| logging.debug(sys.executable) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
kudj
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.