Nuke 12.7 #780

kean · 2024-04-28T00:50:35Z

This PR features re-engineerd Async/Await and AsyncStream support.

…vents

kean added 22 commits April 27, 2024 09:39

Update AsyncImageTask documentation

c7b185b

Add ImageTask/Event

27a252f

Add AsyncImageTask/Event

2dbe607

Implemenet AsyncImageTask/progress and AsyncImageTask/preview using e…

bfbd4dc

…vents

Deprecated AsyncImageTask/previews

92b5409

Re-implement ImagePipeline internals using ImageTask.Event

238be78

Implement Async/Await support using ImageTask.Event

6ad59f7

Implement DataTask using ImageTask

102e129

Remove unused onCancel

baed779

Reuse imageTaskCreated calls

f730cad

Implement loadData reusing most of the loadImage code

6de9721

Move ImageTask (Internal)

a9ad9c0

Remove ImageTask.callbackQueue

e9f09b6

Add AsyncStream.pipe()

fded317

Cleanup loadImage()

e22409c

Deprecated loadData(with:) that accepts URL

c4825c0

Remove unwanted discardableResult

db5595d

Cleanup ImagePipeline

b37eeac

Remove AsyncStream.pipe and replace with standard makeStream(of:)

2c852a6

Cleanup ImagePipeline

7e66e10

Cleanup ImageTask/setState

780ec17

Fix warning in ImageViewPerformanceTests on Swift 6

4a7f2b1

kean force-pushed the async-image-task-events branch from 8594638 to 4a7f2b1 Compare April 28, 2024 01:11

kean added 7 commits April 28, 2024 07:33

Add ImageTask/events (experimental)

c05bd18

Rename ImagePipelineTask to AsyncPipelineTask

7546140

Rename ImagePipeline+ types

a1c5b3a

Remove public events from ImageTask

478385d

Add progress and response async to ImageTask

529d858

Add ImagePipeline/stream

8098328

Start ImageTask eagerly

f5fd09c

Document cancellation behavior

b0ade42

kean force-pushed the async-image-task-events branch from 0c74922 to a871e83 Compare April 30, 2024 01:40

Improve Async/Await support in ImageTask

e4c8579

kean force-pushed the async-image-task-events branch from a871e83 to e4c8579 Compare April 30, 2024 22:43

kean added 9 commits April 30, 2024 18:45

Remove ImageTask/stream

c18ba5f

Model events using PassthroughSubject

4234f0b

Model ImageTask/events using PassthroughSubject

e140a26

Add ImageTask/MutableState

5ba6166

Make the pipeline reference private

b66ba31

Fix flaky DataLoaderTests

d1c2988

ImagePipeline/imageTask(didReceiveEvent:pipeline) delegate method

d4e3f28

Fix strict concurrency warnings when using Atomic

b2c3384

Fix concurrency warnings in CoreImageFilter

72fd1dd

kean force-pushed the async-image-task-events branch 2 times, most recently from 8c304fe to 466c999 Compare May 3, 2024 00:43

Fix more concurrency warnings

8bc6c59

kean force-pushed the async-image-task-events branch from 466c999 to 8bc6c59 Compare May 3, 2024 02:27

Update testAsyncImageTaskEvents

ffaa854

kean force-pushed the async-image-task-events branch from ce1a2ff to 61f8641 Compare May 4, 2024 19:48

Remove flaky testAsyncEvents (no way to gurantee order)

60d06ba

kean force-pushed the async-image-task-events branch from 61f8641 to 60d06ba Compare May 4, 2024 19:48

Use AsyncStream to model ImageTask/events

09f3620

kean force-pushed the async-image-task-events branch 2 times, most recently from 42671e5 to 53a4bb5 Compare May 5, 2024 00:23

Fix flaky tests

acea56d

kean force-pushed the async-image-task-events branch from 53a4bb5 to acea56d Compare May 5, 2024 00:59

kean added 2 commits May 4, 2024 21:33

Fix testImageTaskEvents

cfcf386

Update unit tests to not rely on queue priority

dbb37e4

kean merged commit 97f5323 into main May 5, 2024
8 checks passed

kean deleted the async-image-task-events branch May 5, 2024 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nuke 12.7 #780

Nuke 12.7 #780

kean commented Apr 28, 2024 •

edited

Loading

Nuke 12.7 #780

Nuke 12.7 #780

Conversation

kean commented Apr 28, 2024 • edited Loading

kean commented Apr 28, 2024 •

edited

Loading