Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image loading test #768

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Fix image loading test #768

merged 1 commit into from
Mar 9, 2024

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Mar 9, 2024

This PR fixes ImageViewIntegrationTests.testLoadingWithNilURL() because the test has failed.
Loading an image from an invalid URL should return a data loading error?

@woxtu
Copy link
Contributor Author

woxtu commented Mar 9, 2024

Hmm...

@woxtu woxtu changed the title Fix loading image test Fix image loading test Mar 9, 2024
@kean
Copy link
Owner

kean commented Mar 9, 2024

In this scenarios, the URL is nil, so it throws .imageRequestMissing.

@woxtu
Copy link
Contributor Author

woxtu commented Mar 9, 2024 •
edited
Loading

I figured out the problem. In iOS 17+, URL(string: "http://example.com/invalid url") returns a non-nil value so the test fails.

@kean kean merged commit d658f30 into kean:main Mar 9, 2024
8 checks passed
@woxtu woxtu deleted the patch branch March 10, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woxtu @kean