Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usePlaceholderAsFailure to show placeholder in case of image loading failure #764

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

mlight3
Copy link

@mlight3 mlight3 commented Mar 7, 2024

I added usePlaceholderAsFailure because I think there are a lot of cases where people might want to keep the placeholder visible even if the image fails to load.

@mlight3
Copy link
Author

mlight3 commented Mar 9, 2024

@kean The default value of usePlaceholderAsFailure is true, do you think it should be a false?

@kean
Copy link
Owner

kean commented Mar 23, 2024

Hey, @mlight3 . Thanks for the PR. Yeah, I think it's worth adding.
I usually avoid extending the API surface unless necessary, but it wouldn't hurt.

@kean kean merged commit eb7c5b8 into kean:main Mar 23, 2024
8 checks passed
@kean
Copy link
Owner

kean commented Mar 23, 2024

I changed the default behavior to false and renamed it a bit. Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants