Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip decompression for .png images and other uncompressed formats #788

Open
Pash237 opened this issue May 30, 2024 · 1 comment
Open

Skip decompression for .png images and other uncompressed formats #788

Pash237 opened this issue May 30, 2024 · 1 comment
Labels
feature

Comments

@Pash237
Copy link

Pash237 commented May 30, 2024

Skipping decompression for .png images in bafe72c moves image decoding from multiple background threads to the main thread causing frame drops.

Probably need to double-check that it really worth it, or make it configurable.

Time Profiler before:
before

Time Profiler after:
after
Pash237 referenced this issue May 30, 2024
@kean
Skip decompression for .png images
bafe72c
@kean kean added the bug label May 31, 2024
@kean
Copy link
Owner

kean commented May 31, 2024

I temporarily reverted this change in v12.7.1.

@kean kean changed the title Decompression for .png images is happening on the main thread Skip decompression for .png images and other uncompressed formats Jun 2, 2024
@kean kean added feature and removed bug labels Jun 2, 2024
@Saafo Saafo mentioned this issue Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pash237 @kean