Skip decompression for .png images

Sources/Nuke/Processing/ImageDecompression.swift

@@ -5,6 +5,18 @@
 import Foundation
 
 enum ImageDecompression {
+    static func isDecompressionNeeded(for response: ImageResponse) -> Bool {
+        guard response.container.type != .png else {
+            // Attempting to decompress a `.png` image using
+            // `prepareForReuse` results in the following error:
+            //
+            // [Decompressor] Error -17102 decompressing image -- possibly corrupt
+            //
+            // It's also, in general, inefficient and unnecessary.
+            return false
+        }
+        return isDecompressionNeeded(for: response.image) ?? false
+    }
 
     static func decompress(image: PlatformImage, isUsingPrepareForDisplay: Bool = false) -> PlatformImage {
         image.decompressed(isUsingPrepareForDisplay: isUsingPrepareForDisplay) ?? image

Sources/Nuke/Tasks/TaskLoadImage.swift

@@ -140,9 +140,9 @@ final class TaskLoadImage: ImagePipelineTask<ImageResponse> {
     }
 
     private func isDecompressionNeeded(for response: ImageResponse) -> Bool {
-        !isEphemeral &&
-        (ImageDecompression.isDecompressionNeeded(for: response.image) ?? false) &&
+        ImageDecompression.isDecompressionNeeded(for: response) &&
         !request.options.contains(.skipDecompression) &&
+        !isEphemeral &&
         pipeline.delegate.shouldDecompress(response: response, for: request, pipeline: pipeline)
     }
 
@@ -152,9 +152,7 @@ final class TaskLoadImage: ImagePipelineTask<ImageResponse> {
         guard !isEphemeral else {
             return // Only store for direct requests
         }
-        // Memory cache (ImageCaching)
         pipeline.cache[request] = response.container
-        // Disk cache (DataCaching)
         storeImageInDataCache(response)
     }