feat: Validate inferred generic types (dudykr#1053)

crates/stc_ts_file_analyzer/src/analyzer/generic/expander.rs

@@ -6,7 +6,7 @@ use stc_ts_generics::{
     ExpandGenericOpts,
 };
 use stc_ts_type_ops::Fix;
-use stc_ts_types::{Id, Interface, KeywordType, Readonly, TypeElement, TypeParam, TypeParamDecl, TypeParamInstantiation};
+use stc_ts_types::{Id, Index, Interface, KeywordType, Readonly, TypeElement, TypeParam, TypeParamDecl, TypeParamInstantiation};
 use stc_utils::{cache::Freeze, dev_span, ext::SpanExt};
 use swc_common::{Span, Spanned, TypeEq};
 use swc_ecma_ast::*;
@@ -241,10 +241,7 @@ impl Analyzer<'_, '_> {
 
                 return self.extends(span, child, &parent, opts);
             }
-            _ => {}
-        }
-
-        match parent {
+            Type::Index(Index { ty, .. }) if ty.is_any() && child.is_index() => return Some(true),
             Type::Keyword(KeywordType {
                 kind: TsKeywordTypeKind::TsNullKeyword,
                 ..

crates/stc_ts_file_analyzer/src/analyzer/generic/mod.rs

@@ -6,7 +6,7 @@ use rnode::{Fold, FoldWith, VisitMut, VisitMutWith, VisitWith};
 use stc_ts_ast_rnode::{RBindingIdent, RIdent, RNumber, RPat, RTsEntityName, RTsLit};
 use stc_ts_errors::{
     debug::{dump_type_as_string, force_dump_type_as_string, print_backtrace, print_type},
-    DebugExt,
+    DebugExt, ErrorKind,
 };
 use stc_ts_generics::{
     expander::InferTypeResult,
@@ -128,6 +128,11 @@ impl Analyzer<'_, '_> {
         if let Some(base) = base {
             for (param, type_param) in base.params.iter().zip(type_params) {
                 info!("User provided `{:?} = {:?}`", type_param.name, param.clone());
+
+                if self.validate_generic_argument(span, param, type_param) {
+                    break;
+                }
+
                 inferred.type_params.insert(
                     type_param.name.clone(),
                     InferenceInfo {
@@ -2376,6 +2381,30 @@ impl Analyzer<'_, '_> {
 
         Ok(())
     }
+
+    /// ```ts
+    /// type A<T extends number> = 1;
+    /// A<string>;
+    /// ```
+    fn validate_generic_argument(&mut self, span: Span, param: &Type, type_param: &TypeParam) -> bool {
+        if let Some(tp) = &type_param.constraint {
+            if !param.span().is_dummy() && !param.is_type_param() {
+                if matches!(self.extends(span, param, tp, Default::default()), Some(false)) {
+                    self.storage.report(
+                        ErrorKind::NotSatisfyConstraint {
+                            span: param.span(),
+                            left: tp.clone(),
+                            right: Box::new(param.clone()),
+                        }
+                        .into(),
+                    );
+                    return true;
+                }
+            }
+        }
+
+        false
+    }
 }
 
 fn array_elem_type(t: &Type) -> Option<&Type> {

crates/stc_ts_type_checker/tests/conformance/expressions/functionCalls/overloadResolution.error-diff.json

@@ -1,12 +1,8 @@
 {
   "required_errors": {
-    "TS2344": 1,
     "TS2339": 1
   },
   "required_error_lines": {
-    "TS2344": [
-      81
-    ],
     "TS2339": [
       91
     ]

crates/stc_ts_type_checker/tests/conformance/expressions/functionCalls/overloadResolution.stats.rust-debug

@@ -1,6 +1,6 @@
 Stats {
-    required_error: 2,
-    matched_error: 8,
+    required_error: 1,
+    matched_error: 9,
     extra_error: 0,
     panic: 0,
 }

crates/stc_ts_type_checker/tests/conformance/expressions/functionCalls/overloadResolutionConstructors.error-diff.json

@@ -1,12 +1,8 @@
 {
   "required_errors": {
-    "TS2344": 1,
     "TS2339": 1
   },
   "required_error_lines": {
-    "TS2344": [
-      88
-    ],
     "TS2339": [
       100
     ]

crates/stc_ts_type_checker/tests/conformance/expressions/functionCalls/overloadResolutionConstructors.stats.rust-debug

@@ -1,6 +1,6 @@
 Stats {
-    required_error: 2,
-    matched_error: 8,
+    required_error: 1,
+    matched_error: 9,
     extra_error: 0,
     panic: 0,
 }

crates/stc_ts_type_checker/tests/conformance/expressions/functionCalls/typeArgumentInferenceWithConstraints.error-diff.json

@@ -1,18 +1,10 @@
 {
   "required_errors": {
-    "TS2344": 5,
     "TS2322": 1,
     "TS2403": 1,
     "TS2345": 1
   },
   "required_error_lines": {
-    "TS2344": [
-      11,
-      16,
-      17,
-      35,
-      49
-    ],
     "TS2322": [
       33
     ],

crates/stc_ts_type_checker/tests/conformance/expressions/functionCalls/typeArgumentInferenceWithConstraints.stats.rust-debug

@@ -1,6 +1,6 @@
 Stats {
-    required_error: 8,
-    matched_error: 7,
+    required_error: 3,
+    matched_error: 12,
     extra_error: 2,
     panic: 0,
 }

crates/stc_ts_type_checker/tests/conformance/types/conditional/conditionalTypes1.error-diff.json

@@ -31,14 +31,14 @@
   },
   "extra_errors": {
     "TS2322": 1,
-    "TS0": 1
+    "TS2344": 1
   },
   "extra_error_lines": {
     "TS2322": [
       21
     ],
-    "TS0": [
-      323
+    "TS2344": [
+      317
     ]
   }
 }

crates/stc_ts_type_checker/tests/conformance/types/mapped/mappedTypeErrors.error-diff.json

@@ -2,7 +2,7 @@
   "required_errors": {
     "TS2313": 1,
     "TS2322": 4,
-    "TS2344": 7,
+    "TS2344": 5,
     "TS2403": 4,
     "TS2345": 4,
     "TS2536": 1,
@@ -19,11 +19,9 @@
       139
     ],
     "TS2344": [
-      25,
       28,
       29,
       31,
-      33,
       36,
       40
     ],

crates/stc_ts_type_checker/tests/conformance/types/mapped/mappedTypeErrors.stats.rust-debug

@@ -1,6 +1,6 @@
 Stats {
-    required_error: 23,
-    matched_error: 4,
+    required_error: 21,
+    matched_error: 6,
     extra_error: 16,
     panic: 0,
 }

crates/stc_ts_type_checker/tests/conformance/types/nonPrimitive/nonPrimitiveInGeneric.stats.rust-debug

@@ -1,6 +1,6 @@
 Stats {
-    required_error: 3,
-    matched_error: 5,
+    required_error: 0,
+    matched_error: 8,
     extra_error: 0,
     panic: 0,
 }

crates/stc_ts_type_checker/tests/conformance/types/nonPrimitive/nonPrimitiveStrictNull.error-diff.json

@@ -4,8 +4,7 @@
     "TS2339": 1,
     "TS2531": 3,
     "TS2532": 3,
-    "TS2533": 1,
-    "TS2344": 3
+    "TS2533": 1
   },
   "required_error_lines": {
     "TS2454": [
@@ -26,11 +25,6 @@
     ],
     "TS2533": [
       34
-    ],
-    "TS2344": [
-      53,
-      54,
-      55
     ]
   },
   "extra_errors": {},

crates/stc_ts_type_checker/tests/conformance/types/nonPrimitive/nonPrimitiveStrictNull.stats.rust-debug

@@ -1,6 +1,6 @@
 Stats {
-    required_error: 12,
-    matched_error: 6,
+    required_error: 9,
+    matched_error: 9,
     extra_error: 0,
     panic: 0,
 }

crates/stc_ts_type_checker/tests/conformance/types/rest/genericRestParameters1.error-diff.json

@@ -1,12 +1,8 @@
 {
   "required_errors": {
-    "TS2344": 1,
     "TS2322": 1
   },
   "required_error_lines": {
-    "TS2344": [
-      138
-    ],
     "TS2322": [
       167
     ]

crates/stc_ts_type_checker/tests/conformance/types/rest/genericRestParameters1.stats.rust-debug

@@ -1,6 +1,6 @@
 Stats {
-    required_error: 2,
-    matched_error: 0,
+    required_error: 1,
+    matched_error: 1,
     extra_error: 1,
     panic: 0,
 }

crates/stc_ts_type_checker/tests/conformance/types/specifyingTypes/typeQueries/circularTypeofWithVarOrFunc.error-diff.json

@@ -23,21 +23,24 @@
     ]
   },
   "extra_errors": {
-    "TS2304": 5,
-    "TS2322": 3
+    "TS2304": 3,
+    "TS2322": 3,
+    "TS2344": 2
   },
   "extra_error_lines": {
     "TS2304": [
       1,
       5,
-      9,
-      18,
-      25
+      9
     ],
     "TS2322": [
       7,
       20,
       26
+    ],
+    "TS2344": [
+      18,
+      25
     ]
   }
 }

crates/stc_ts_type_checker/tests/tsc-stats.rust-debug

@@ -1,6 +1,6 @@
 Stats {
-    required_error: 3518,
-    matched_error: 6517,
+    required_error: 3502,
+    matched_error: 6533,
     extra_error: 769,
     panic: 74,
 }