Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: switch to new edx-platform asset build #37

Closed
wants to merge 1 commit into from

Conversation

kdmccormick
Copy link
Owner

@kdmccormick kdmccormick commented Oct 5, 2023

WIP. If merged, this would switch Tutor over to the new assets build (npm run build) with no other improvements.

In contrast, #34 would switch Tutor over to the new assets build, plus a bunch of other changes and improvements.

TODO:

  • Remove 'experimental' warnings
  • Test dev & prod builds one last time
  • Test sass-watching again
    • should it be called watchsass instead of watchthemes now?
    • or should we add a flag to npm run watch-sass to exclude default theme?
    • does it work with bind-mounted edx-platform?
  • Print warning in openedx-assets
  • Add REMOVE-AFTER-VXX comments
  • Update docs

@kdmccormick kdmccormick reopened this Mar 18, 2024
@kdmccormick kdmccormick changed the title build: switch to new edx-platform asset build feat!: switch to new edx-platform asset build Mar 18, 2024
@kdmccormick kdmccormick force-pushed the kdmccormick/assets-build branch 6 times, most recently from 7e9a35e to b062098 Compare April 18, 2024 04:12
BREAKING CHANGE: `openedx-assets` is replaed with `npm run` subcommands.
For details, see the changelog entry.
For further details and rationale, see the upstream DEPR ticket:
openedx/edx-platform#31895
@kdmccormick kdmccormick deleted the kdmccormick/assets-build branch April 18, 2024 04:14
@kdmccormick kdmccormick restored the kdmccormick/assets-build branch April 18, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant