Skip to content

Commit

Permalink
fix: fix alert icon unexpected behaviour (openedx#32455)
Browse files Browse the repository at this point in the history
  • Loading branch information
@NawfalAhmed
NawfalAhmed authored Jun 14, 2023
1 parent 489e239 commit ee72134
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
2 changes: 1 addition & 1 deletion lms/static/images/warning-icon.svg
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 4 additions & 8 deletions lms/templates/learner_dashboard/program_details_tab_view.underscore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,15 @@
<% if (completedCount === totalCount) { %>
<h2 class="program-heading-title"><%- gettext('Congratulations!') %></h2>
<div class="program-heading-message">
<div><%- interpolate(gettext(
'You have successfully completed all the requirements for the %(title)s %(type)s.'),
<div><%- interpolate(gettext('You have successfully completed all the requirements for the %(title)s %(type)s.'),
{ title: title, type: type }, true) %>
</div>
</div>
<% } else { %>
<h2 class="program-heading-title"><%- gettext('Your Program Journey') %></h2>
<div class="program-heading-message">
<div>
<%- interpolate(gettext(
'Track and plan your progress through the %(count)s course(s) in this program. To complete the program, you must earn a verified certificate for each course.'),
<%- interpolate(gettext('Track and plan your progress through the %(count)s course(s) in this program. To complete the program, you must earn a verified certificate for each course.'),
{ count: totalCount }, true) %>
</div>
</div>
Expand Down Expand Up @@ -177,12 +175,10 @@
<aside class="col-md-4 program-heading">
<h2 class = "divider-heading program-heading-title"><%- gettext('Additional Credit Opportunities') %></h2>
<div class="program-heading-message">
<div class="pb-4"><%- interpolate(gettext(
'Transform your %(org)s %(type)s into a full master’s degree'),
<div class="pb-4"><%- interpolate(gettext('Transform your %(org)s %(type)s into a full master’s degree'),
{ org: authoring_organizations[0].key, type: type }, true) %>
</div>
<div class="pb-4"><%- interpolate(gettext(
'Successful completion of %(org)s %(program)s credential can be applied towards flexible, rigorous, and affordable masters degrees from the world’s leading universities.'),
<div class="pb-4"><%- interpolate(gettext('Successful completion of %(org)s %(program)s credential can be applied towards flexible, rigorous, and affordable masters degrees from the world’s leading universities.'),
{org: authoring_organizations[0].key, program: title}, true) %>
</div>
</div>
Expand Down
6 changes: 2 additions & 4 deletions lms/templates/learner_dashboard/program_details_view.underscore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,15 @@
<% if (completedCount === totalCount) { %>
<h3 class="program-heading-title"><%- gettext('Congratulations!') %></h3>
<div class="program-heading-message">
<div><%- interpolate(gettext(
'You have successfully completed all the requirements for the %(title)s %(type)s.'),
<div><%- interpolate(gettext('You have successfully completed all the requirements for the %(title)s %(type)s.'),
{ title: title, type: type }, true) %>
</div>
</div>
<% } else { %>
<h3 class="program-heading-title"><%- gettext('Your Program Journey') %></h3>
<div class="program-heading-message">
<div>
<%- interpolate(gettext(
'Track and plan your progress through the %(count)s courses in this program. To complete the program, you must earn a verified certificate for each course.'),
<%- interpolate(gettext('Track and plan your progress through the %(count)s courses in this program. To complete the program, you must earn a verified certificate for each course.'),
{ count: totalCount }, true) %>
</div>
</div>
Expand Down

0 comments on commit ee72134

Please sign in to comment.