Merge pull request #10 from takaram/fix-gvar-op-asgn

Fix self assignment node with global vars
kddnewton · Jan 17, 2024 · 3259598 · 3259598
2 parents e0fc1c4 + 828457b
commit 3259598
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/lib/parser/prism/compiler.rb b/lib/parser/prism/compiler.rb
@@ -657,7 +657,7 @@ def visit_global_variable_write_node(node)
     def visit_global_variable_operator_write_node(node)
       builder.op_assign(
         builder.assignable(builder.gvar(token(node.name_loc))),
-        [node.operator, srange(node.operator_loc)],
+        [node.operator_loc.slice.chomp("="), srange(node.operator_loc)],
         visit(node.value)
       )
     end

diff --git a/test/fixtures/and_asgn.rb b/test/fixtures/and_asgn.rb
@@ -1,3 +1,5 @@
 foo.a &&= 1
 
 foo[0, 1] &&= 2
+
+$foo &&= 1
diff --git a/test/fixtures/op_asgn.rb b/test/fixtures/op_asgn.rb
@@ -3,3 +3,5 @@
 foo.a += 1
 
 foo::a += 1
+
+$foo += 1
diff --git a/test/fixtures/or_asgn.rb b/test/fixtures/or_asgn.rb
@@ -1,3 +1,5 @@
 foo.a ||= 1
 
 foo[0, 1] ||= 2
+
+$foo ||= 1