Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ authorizer: allow configuring the order of authorizers #3281

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cnvergence
Copy link
Contributor

@cnvergence cnvergence commented Jan 30, 2025

Summary

Provide --authorization-modes flag that allows kcp administrator to tune the authorizer behaviour and rearrange the order. If not specified it will maintain the default one as: AlwaysAllowGroups, AlwaysAllowPaths, Webhook, RBAC.

Related issue(s)

Fixes

Release Notes

Provide `--authorization-modes` flag that allows kcp administrator to tune the authorizer behaviour and rearrange the order.

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jan 30, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign scheeles for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2025
@kcp-ci-bot
Copy link
Contributor

Hi @cnvergence. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2025
@cnvergence cnvergence force-pushed the add-authorizers-order branch from 0e4ba40 to 00c93e6 Compare January 31, 2025 15:06
@cnvergence cnvergence force-pushed the add-authorizers-order branch from 00c93e6 to 8c89fc1 Compare January 31, 2025 15:09
@embik
Copy link
Member

embik commented Feb 3, 2025

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2025
@cnvergence
Copy link
Contributor Author

/retest

@cnvergence cnvergence changed the title ✨ WIP Configure order of authorizers ✨ authorizer: allow configuring the order of authorizers Feb 3, 2025
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 3, 2025
@cnvergence cnvergence marked this pull request as ready for review February 3, 2025 15:42
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2025
@cnvergence
Copy link
Contributor Author

/retest

@embik embik added this to the v0.27.0 milestone Feb 4, 2025
@cnvergence cnvergence force-pushed the add-authorizers-order branch 2 times, most recently from 76e73eb to a286bbc Compare February 4, 2025 15:13
@cnvergence cnvergence force-pushed the add-authorizers-order branch from a286bbc to 75cf096 Compare February 4, 2025 16:17
@kcp-ci-bot kcp-ci-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 4, 2025
@kcp-ci-bot kcp-ci-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 4, 2025
Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
@cnvergence
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants