Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: 🐛 authentication: add custom SA lookup with ttl cache for non-local clusters #3274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sttts
Copy link
Member

@sttts sttts commented Jan 26, 2025

Summary

With service accounts valid (even as system:anonymous+system:authenticated) on other clusters, we have to validate them on other shards. As there are many service accounts, we cannot distribute them via the cache server. But luckily there are not many those service accounts. We can use some ttl cache for that and use a real external client.

TODO

  • wire external client

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jan 26, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sttts. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 26, 2025
@kcp-ci-bot
Copy link
Contributor

@sttts: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-test-e2e c6c34c8 link true /test pull-kcp-test-e2e
pull-kcp-test-e2e-multiple-runs c6c34c8 link true /test pull-kcp-test-e2e-multiple-runs
pull-kcp-test-e2e-sharded c6c34c8 link true /test pull-kcp-test-e2e-sharded
pull-kcp-test-e2e-shared c6c34c8 link true /test pull-kcp-test-e2e-shared
pull-kcp-test-unit c6c34c8 link true /test pull-kcp-test-unit
pull-kcp-lint c6c34c8 link true /test pull-kcp-lint

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@embik embik added this to the v0.27.0 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants