Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Rebase for k/k 1.32 #81

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

✨ Rebase for k/k 1.32 #81

wants to merge 3 commits into from

Conversation

gman0
Copy link
Contributor

@gman0 gman0 commented Dec 17, 2024 •
edited
Loading

Summary

Related issue(s)

Part of kcp-dev/kcp#3209

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2024
@kcp-ci-bot
Copy link
Contributor

Hi @gman0. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2024
@gman0 gman0 changed the title ✨ Rebase for k/k 1.32 Draft: ✨ Rebase for k/k 1.32 Dec 17, 2024
@gman0
Copy link
Contributor Author

gman0 commented Dec 17, 2024

I've marked this PR as draft for the moment until I find out why golangci-lint is crashing:

ERRO [linters_context/goanalysis] nilness: panic during analysis: internal error: unhandled type *ir.ArrayConst, goroutine 4064 [running]:
runtime/debug.Stack()
	/usr/lib/golang/src/runtime/debug/stack.go:26 +0x5e
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyzeSafe.func1()
	/home/rvasek/go/pkg/mod/github.com/golangci/[email protected]/pkg/goanalysis/runner_action.go:105 +0x5a
panic({0x17a6b20?, 0xc00414c0e0?})
	/usr/lib/golang/src/runtime/panic.go:785 +0x132
honnef.co/go/tools/analysis/facts/nilness.impl.func1({0x7fdb84141650, 0xc00553b860})
	/home/rvasek/go/pkg/mod/honnef.co/go/[email protected]/analysis/facts/nilness/nilness.go:239 +0x8a5
honnef.co/go/tools/analysis/facts/nilness.impl.func1({0x1cbec38, 0xc0013a6c00})
	/home/rvasek/go/pkg/mod/honnef.co/go/[email protected]/analysis/facts/nilness/nilness.go:147 +0x90e
honnef.co/go/tools/analysis/facts/nilness.impl(0xc0012c10a0, 0xc000fa57c0, 0xc0055abcb8)
	/home/rvasek/go/pkg/mod/honnef.co/go/[email protected]/analysis/facts/nilness/nilness.go:246 +0x32a
honnef.co/go/tools/analysis/facts/nilness.run(0xc0012c10a0)
	/home/rvasek/go/pkg/mod/honnef.co/go/[email protected]/analysis/facts/nilness/nilness.go:66 +0x125
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyze(0xc0034a35a0)
	/home/rvasek/go/pkg/mod/github.com/golangci/[email protected]/pkg/goanalysis/runner_action.go:191 +0x9cd
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyzeSafe.func2()
	/home/rvasek/go/pkg/mod/github.com/golangci/[email protected]/pkg/goanalysis/runner_action.go:113 +0x17
github.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc000ec7040, {0x19cb761, 0x7}, 0xc003eec748)
	/home/rvasek/go/pkg/mod/github.com/golangci/[email protected]/pkg/timeutils/stopwatch.go:111 +0x44
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyzeSafe(0xc00150d500?)
	/home/rvasek/go/pkg/mod/github.com/golangci/[email protected]/pkg/goanalysis/runner_action.go:112 +0x6e
github.com/golangci/golangci-lint/pkg/goanalysis.(*loadingPackage).analyze.func2(0xc0034a35a0)
	/home/rvasek/go/pkg/mod/github.com/golangci/[email protected]/pkg/goanalysis/runner_loadingpackage.go:80 +0xa5
created by github.com/golangci/golangci-lint/pkg/goanalysis.(*loadingPackage).analyze in goroutine 1114
	/home/rvasek/go/pkg/mod/github.com/golangci/[email protected]/pkg/goanalysis/runner_loadingpackage.go:75 +0x1e9

@gman0
Makefile: updated golangci-lint to v1.62.2
ad98146 
The previous version v1.58.1 we were using was panicking:

    ERRO [linters_context/goanalysis] nilness: panic during analysis: internal error: unhandled type *ir.ArrayConst,

On-behalf-of: SAP [email protected]
Signed-off-by: Robert Vasek <[email protected]>
@gman0 gman0 changed the title Draft: ✨ Rebase for k/k 1.32 ✨ Rebase for k/k 1.32 Dec 17, 2024
mjudeikis
mjudeikis reviewed Dec 17, 2024
View reviewed changes
Makefile
@@ -19,7 +19,7 @@ GO_INSTALL = ./hack/go-install.sh
TOOLS_DIR=hack/tools
GOBIN_DIR := $(abspath $(TOOLS_DIR))

GOLANGCI_LINT_VER := v1.58.1
GOLANGCI_LINT_VER := v1.62.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we revert, still fails linting?

Copy link
Contributor Author

@gman0 gman0 Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It crashes immediately after running make lint test locally, even without any changes done. The stack trace suggests the issue is inside golangci-lint itself. Indeed it's strange that it should crash when it must have worked before; perhaps related to go1.23 or the dependencies used. In any case, do we want to keep the older version at all? Or we update in a separate PR?

@mjudeikis
Copy link
Contributor

/lgtm
/approve
/hold

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4509b23f78d51ed96c4023c4a763a8c769670c81

@gman0
Copy link
Contributor Author

gman0 commented Dec 17, 2024 •
edited
Loading 

docker run --rm ghcr.io/kcp-dev/infra/build:1.22.10-1 go version
go version go1.22.10 linux/amd64

1.22.10-1 is the latest tag we have. Can we build a new one with more recent go toolkit?

I've opened kcp-dev/infra#78

@sttts
Copy link
Member

sttts commented Dec 17, 2024

/ok-to-test
/lgtm
/approve

Lint and test are unhappy.

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2024
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@sttts
Copy link
Member

sttts commented Dec 18, 2024

/retest

3 similar comments
@gman0
Copy link
Contributor Author

gman0 commented Dec 20, 2024

/retest

@mjudeikis
Copy link
Contributor

/retest

@gman0
Copy link
Contributor Author

gman0 commented Dec 25, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjudeikis mjudeikis mjudeikis left review comments

Assignees

@sttts sttts

@mjudeikis mjudeikis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gman0 @kcp-ci-bot @mjudeikis @sttts