-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lfx pre test lsp quick fix #1038
lfx pre test lsp quick fix #1038
Conversation
Signed-off-by: Shashank Mittal <[email protected]>
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Signed-off-by: Shashank Mittal <[email protected]>
Pull Request Test Coverage Report for Build 7951445687Details
💛 - Coveralls |
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Hey @He1pa , I have added test in |
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job! LGTM!
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
Close #1020
2. What is the scope of this PR (e.g. component or file name):
Adding LSP quick fix
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Screen.Recording.2024-02-12.at.11.57.54.PM.mov
pub data: Option<serde_json::Value>
, excluded data from hash calculation due to its json typeadd_compile_error
to work when data field is Nonelookup_type_from_scope()
andset_type_to_scope()
conver_code_to_kcl_diag_id
for CompileErrorquick_fix
to replace new_text with suggested_replacementkcl_diag_to_lsp_diags
to convert data field of KCL diagnostics to data field of LSP diagnostics.4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: