Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added kpm_update #1032

Closed
wants to merge 7 commits into from
Closed

added kpm_update #1032

wants to merge 7 commits into from

Conversation

octonawish-akcodes
Copy link
Contributor

@octonawish-akcodes octonawish-akcodes commented Feb 5, 2024 •
edited
Loading

Tried to implement the kcl mod update similar to the metadata, Any guidance about how to add the integration with the LSP? #1031

cc @Peefy @zong-zhe @He1pa

@coveralls
Copy link
Collaborator

coveralls commented Feb 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7811178585

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.767%
Totals Coverage Status
Change from base Build 7798962109: 0.0%
Covered Lines: 2303
Relevant Lines: 2624
💛 - Coveralls

@octonawish-akcodes
added kpm_update
b077e74 
Signed-off-by: Abhishek Kumar <[email protected]>
@octonawish-akcodes octonawish-akcodes mentioned this pull request Feb 5, 2024
Closed
@octonawish-akcodes octonawish-akcodes force-pushed the ts branch 2 times, most recently from 21a6210 to fda64ed Compare February 6, 2024 09:44
@octonawish-akcodes
refactor
1f56f64 
Signed-off-by: Abhishek Kumar <[email protected]>
@octonawish-akcodes octonawish-akcodes force-pushed the ts branch 2 times, most recently from e4657b0 to 56d3878 Compare February 7, 2024 04:07
@octonawish-akcodes octonawish-akcodes force-pushed the ts branch 3 times, most recently from 88c2ec5 to 296694b Compare February 7, 2024 07:09
@octonawish-akcodes
Copy link
Contributor Author

octonawish-akcodes commented Feb 21, 2024 •
edited
Loading

I added the passing test cases too @Peefy @zong-zhe

@octonawish-akcodes
test cases fix
f59a206 
Signed-off-by: Abhishek Kumar <[email protected]>
@Peefy
Copy link
Contributor

Peefy commented Feb 21, 2024

I added the passing test cases too @Peefy @zong-zhe

PR conflict, can you rebase the main branch and refactor it?

@octonawish-akcodes
Copy link
Contributor Author

@Peefy check now?

Peefy
Peefy reviewed Feb 21, 2024
View reviewed changes
kclvm/driver/src/tests.rs Outdated Show resolved Hide resolved
@octonawish-akcodes
formatted code
8642ac2 
Signed-off-by: Abhishek Kumar <[email protected]>
@Peefy
Copy link
Contributor

Peefy commented Feb 21, 2024

@Peefy check now?

Thank you! Please sign the DCO

Peefy
Peefy reviewed Feb 21, 2024
View reviewed changes
kclvm/driver/src/tests.rs
}
let result = update_kcl_module(manifest_path);
assert!(result.is_err());
fn test_update_module() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @octonawish-akcodes CI failed and would you please sign the DCO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im inspecting that, and i am having trouble signing dco due to conflicts :/

@octonawish-akcodes
Copy link
Contributor Author

im having issues while working on this PR new PR is raised here with better commit messages and clean implementation #1071

cc @Peefy @zong-zhe

@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Peefy Peefy Peefy left review comments

@zong-zhe zong-zhe Awaiting requested review from zong-zhe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@octonawish-akcodes @coveralls @Peefy @zong-zhe