improvement to toast.promise #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@kbrgl what do you think about this? |
| }) | ||
| .catch((e) => { | ||
| toast.remove(id) | ||
| toast.error(msgs.error ?? e, { |
There was a problem hiding this comment.
p can be an object, right? what if I want to use from the p a specific property?
Example:
p = { errorMessage: "Something went wrong" } - in this case, I want to use p.errorMessage.
There was a problem hiding this comment.
This is already possible - that is the purpose of resolveValue
toast.promise(
new Promise((resolve) => resolve({
successMsg: 'Success from promise'
})),
{
loading: 'Laoding',
success: function(result) {
return result.successMsg;
},
error: 'Error',
}
)
You can pass a function instead of a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve the following issues for
toast.promisesupport dynamic toast message based on promise's result, fallback to the static message provided initially
handle edge case where
toast.loadinghas been set with{duration: Infinity}, andtoast.successandtoast.errorwill not go away as wellThe only thing that I am not sure is why is
resolveValuefunction used there previously.