forked from symfony/ux
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native Attributes #1
Open
kbond
wants to merge
5
commits into
2.x
Choose a base branch
from
attributes-3
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
pushed a commit
that referenced
this pull request
Sep 13, 2023
I have a custom hydration extension that in `supports` method checks if the provided class has my custom marker attribute through Reflection, but SA complains: > Parameter #1 $objectOrClass of class ReflectionClass constructor expects class-string<T of object>|T of object, string given.
kbond
pushed a commit
that referenced
this pull request
Sep 13, 2023
…ExtensionInterface (norkunas) This PR was merged into the 2.x branch. Discussion ---------- [LiveComponent] Add missing typehints to HydrationExtensionInterface | Q | A | ------------- | --- | Bug fix? | no /not sure | New feature? | no /not sure | Tickets | N/A | License | MIT I have a custom hydration extension that in `supports` method checks if the provided class has my custom marker attribute through Reflection, but SA complains: > Parameter `#1` $objectOrClass of class ReflectionClass constructor expects class-string<T of object>|T of object, string given. Commits ------- 7f8279c [LiveComponent] Add missing typehints to HydrationExtensionInterface
kbond
added a commit
that referenced
this pull request
Apr 24, 2024
…ceLoader if the parent $loader is null (vesselind) This PR was merged into the 2.x branch. Discussion ---------- symfony#1770 [Autocomplete] Ignore the ExtraLazyChoiceLoader if the parent $loader is null | Q | A | ------------- | --- | Bug fix? | yes/no | New feature? | no | Issues | Fix symfony#1770 | License | MIT When a custom autoload field class is created and `choices` option is passed, an error occurs: `Symfony\UX\Autocomplete\Form\ChoiceList\Loader\ExtraLazyChoiceLoader::__construct(): Argument #1 ($decorated) must be of type Symfony\Component\Form\ChoiceList\Loader\ChoiceLoaderInterface, null given`. This should fix the problem, described in symfony#1770. Commits ------- 28af7fc symfony#1770 ignore the ExtraLazyChoiceLoader if the parent $loader is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.