Skip to content

Show Frame and Ignore Favicon GET #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Show Frame and Ignore Favicon GET #1

wants to merge 6 commits into from

Conversation

jwatson-CO-edu
Copy link

  1. Both FF and Chrome request favicon by default. Since the lib comes with no assets, ignore such requests by applying the fix suggested by https://stackoverflow.com/a/38917888
  2. Neither the README examples nor those in "examples/" ask the context to render the frame, added context.ShowFrame() statements to both.

jwatson-CO-edu and others added 6 commits January 18, 2021 18:52
@jwatson-CO-edu
Update httpcanvas.go
e2032ff
@jwatson-CO-edu
Update README.md
3b280bf 
Add `context.ShowFrame` to the README example so that it displays.
@jwatson-CO-edu
Update circle.go
a38c7d1 
Show the frame
@jwatson-CO-edu
Update line.go
e1def67 
show the frame
@jwatson-CO-edu
Update lines.go
8b1523f 
show the frame
@jwatson-CO-edu
Moved the template HTML to its own file for clarity
90b42c1
@jwatson-CO-edu
Copy link
Author

Moved the HTML template to it's own file. renderHtml loads this file at serve time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jwatson-CO-edu