-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a workspace client module #738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything in client/src is SDK generated
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-gradle2 #738 +/- ##
==============================================
Coverage 87.78% 87.78%
Complexity 5328 5328
==============================================
Files 228 228
Lines 17598 17598
Branches 2585 2585
==============================================
Hits 15448 15448
Misses 1694 1694
Partials 456 456 |
how to make sure generated code is up to date? |
./gradlew sdkCompile compiles the generated code for both the client and server subprojects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a clunky solution but if there aren't any alternatives...
It's 100% clunky. It's just the least clunky option I'm aware of |
When ya gotta clunk, ya gotta clunk. |
The purpose of this module is to allow for serving the workspace client jar out of jitpack.io, which can only serve 1 jar per module.
I figured this approach was better than making a separate repo and having to sync over the spec, make sure the github releases were equivalent & up to date, etc.
The drawback is the duplicate generated code, but a 2nd repo would have that drawback as well.