Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workspace client module #738

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

MrCreosote
Copy link
Member

The purpose of this module is to allow for serving the workspace client jar out of jitpack.io, which can only serve 1 jar per module.

I figured this approach was better than making a separate repo and having to sync over the spec, make sure the github releases were equivalent & up to date, etc.

The drawback is the duplicate generated code, but a 2nd repo would have that drawback as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in client/src is SDK generated

@MrCreosote MrCreosote changed the title Add a worksapce client module Add a workspace client module May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.78%. Comparing base (d3e894d) to head (b55a0eb).
Report is 13 commits behind head on dev-gradle2.

Additional details and impacted files
@@              Coverage Diff               @@
##             dev-gradle2     #738   +/-   ##
==============================================
  Coverage          87.78%   87.78%           
  Complexity          5328     5328           
==============================================
  Files                228      228           
  Lines              17598    17598           
  Branches            2585     2585           
==============================================
  Hits               15448    15448           
  Misses              1694     1694           
  Partials             456      456           

@Xiangs18
Copy link
Collaborator

Xiangs18 commented May 3, 2024

how to make sure generated code is up to date?

@MrCreosote
Copy link
Member Author

./gradlew sdkCompile compiles the generated code for both the client and server subprojects

Copy link
Collaborator

@ialarmedalien ialarmedalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a clunky solution but if there aren't any alternatives...

@MrCreosote
Copy link
Member Author

It's 100% clunky. It's just the least clunky option I'm aware of

@ialarmedalien
Copy link
Collaborator

When ya gotta clunk, ya gotta clunk.

@MrCreosote MrCreosote merged commit f411a05 into dev-gradle2 May 6, 2024
4 checks passed
@MrCreosote MrCreosote deleted the dev-gradle2_upstream branch May 8, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants