Use jitpack jars and publish shadow jar #736
Conversation
Javadocs link properly Also remove ServiceChecker, it's completely unused at this point
| } | ||
| // TODO DEPS Need to rework the java common logger to not use syslog4j at all since it's | ||
| // abandonware and has a ton of CVEs, even in the newer versions. | ||
| implementation "org.syslog4j:syslog4j:0.9.46" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-gradle2 #736 +/- ##
=================================================
+ Coverage 87.75% 87.78% +0.02%
+ Complexity 5333 5328 -5
=================================================
Files 229 228 -1
Lines 17647 17598 -49
Branches 2591 2585 -6
=================================================
- Hits 15486 15448 -38
+ Misses 1701 1694 -7
+ Partials 460 456 -4 |
build.gradle
Outdated
| * here. | ||
| * https://github.com/marketplace/actions/deploy-publish-javadoc | ||
| * https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-gradle-registry | ||
| */ | ||
| /* TODO DOCS the current sdk documenation looks like invalid html to javadoc |
There was a problem hiding this comment.
fingers crossed this will be removed soon anyway, but there's a T missing in documentation
| implementation 'com.github.ben-manes.caffeine:caffeine:2.9.3' | ||
| implementation "com.github.kbase:auth2_client_java:$VER_AUTH2_CLIENT" | ||
| implementation("com.github.kbase:handle_service2:1.0.6") { |
| When creating an application using the WSS it's advisable to use a build tool | ||
| like ``ant``, ``maven``, or ``gradle`` to organize the required jars. |
There was a problem hiding this comment.
Should this be updated to just recommend gradle?
There was a problem hiding this comment.
I don't think so, maven should work with jitpack, and you can download the jars for ant or use ivy
docsource/releasenotes.rst
Outdated
| @@ -16,6 +16,7 @@ UPDATES: | |||
| against Mongo 7. | |||
| * Gradle has replaced Ant as the build tool. As a consequence, all the built artifacts are now | |||
| located in the build directory, including the ``update_workspace_database_schema`` script. | |||
| * A shadow jar is published on jitpack.io for supporting tests in other repos. | |||
There was a problem hiding this comment.
Add a short explanation of what a shadow jar is so people can get the gist without having to google it.
| final String authUrl = "https://appdev.kbase.us/services/auth/"; | ||
| final AuthClient authcli = AuthClient.from(new URI(authUrl)); |
There was a problem hiding this comment.
why switch from CI to appdev?
There was a problem hiding this comment.
Because this documentation is targeted at 3rd app developers as well as kbase developers and they're much more likely to have an appdev/prod account than a ci account
Javadocs link properly
Also remove ServiceChecker, it's completely unused at this point