-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend python versions testing runs against #654
base: master
Are you sure you want to change the base?
Extend python versions testing runs against #654
Conversation
Suggest adding lines to |
ad97d42
to
01055b2
Compare
Is this a good time to remove 2.7? |
Imho any time is. |
Mhm. And the tox file has some version references I missed as well. |
70af119 'Extend python versions testing run against. '
- 3.10: released on 2021-10-04 - 3.11: released on 2022-10-24
- sunsetted on 2020-01-01
01055b2
to
d7d02ba
Compare
I think that's it. The previous updater missed 3.9 in |
I dropped three unsupported compat scenarios and will follow up with PRs removing their artifacts after making sure they're not used anywhere. @obormot Any idea, why |
no clue, but try changing run-on: ubuntu-20.04 to ubuntu-latest (which doesn't include python2), and see if it helps? |
to use ubuntu-latest again reverts the workaround from kbandla#652 and resolves kbandla#651
@obormot Python 3.5 is missing on Ubuntu20 as well. To be specific: I'd suggest getting rid of already sunsetted versions. |
- sunsetted on 2020-09-30
- sunsetted on 2021-12-23
I think the reason 2.7, 3.5 and 3.6 builds are still "expected", may be branch protection rules, which are defined in the repo settings (available to @kbandla). Reference: https://github.com/orgs/community/discussions/26698 |
pypy defaultet to the (unsupported) version 3.6 as per setup-python action v2. We always tested for one pypy version and not all supported. If we want to test for more let me know and I'll update this PR accordingly. After @kbandla resolved that this might be good to go. |
updated the branch protection settings for master (removed 2.7-3.5). I will add another rule for the 2.7 branch, when we freeze it. |
Then this is ready for review; |
This looks good to me. Not sure about pypy, never used it. We can update the README separately once the 2.7 support branch is up. |
Similar to #554 two years ago.