Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On windows, check if the file is opened in binary mode #369

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

On windows, check if the file is opened in binary mode #369

wants to merge 4 commits into from

Commits on Jun 1, 2017

  1. On windows, check if the file is opened in binary mode

    kbandla committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    162ad76 View commit details
    Browse the repository at this point in the history

  2. Fix typo for pcap.Writer

    kbandla committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    fad3d74 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Expand checks to all OS 

    While testing the PR some more, I noticed that python3 on Linux did
not open in binary mode when we do no pass 'b'. Therefore it seemed
appropriate to expand this check to all OS, and not just windows.
    @kbandla
    kbandla committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    bdc5027 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Merge branch 'master' into pcap_binary_mode

    @brifordwylie
    brifordwylie authored Mar 29, 2022
    Configuration menu
    Copy the full SHA
    5402e2f View commit details
    Browse the repository at this point in the history