refactor: option name

kawamataryo · Dec 17, 2022 · 24438ae · 24438ae
1 parent 7aa24bb
commit 24438ae
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 19 deletions.
diff --git a/README.md b/README.md
@@ -71,6 +71,7 @@ jobs:
 |BACKGROUND_END|`#0E5593`|カード背景のグラデーションの end color|
 |LANG|`ja`|スコアの表記方法（`ja` or `en`）|
 |CARD_WIDTH|`400`|出力する画像のwidth|
+|UPDATE_TIME|`true`|スコアの更新日時の表示有無|
 
 [lapras-card-generator](https://lapras-card-generator.vercel.app) を使うことで生成画像のPreviewや、環境変数の出力も可能です。
 
@@ -79,4 +80,3 @@ jobs:
 Exportボタンの `GitHub Actions params` で、環境変数をコピーできます。
 
 ![CleanShot 2022-12-17 at 21 41 44](https://user-images.githubusercontent.com/11070996/208242401-decb0cbb-c2dd-4ce4-832b-8ae83d6e74aa.png)
-
diff --git a/action.yml b/action.yml
@@ -33,10 +33,10 @@ inputs:
     required: false
     description: 'card width'
     default: '400'
-  HIDE_UPDATE_TIME:
+  UPDATE_TIME:
     required: false
-    description: 'hide update time'
-    default: 'false'
+    description: 'display of score update date and time'
+    default: 'true'
 runs:
   using: 'node16'
   main: 'dist/index.js'

diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/lib/rewriteReadmeToIncludeCardText.ts b/src/lib/rewriteReadmeToIncludeCardText.ts
@@ -7,14 +7,14 @@ const createCardText = ({
   theme,
   lang,
   cardWidth,
-  hideUpdateTime,
+  showUpdateTime,
 }: {
   shareId: string
   score: Score
   theme: Theme
   lang: Language
   cardWidth: string
-  hideUpdateTime: boolean
+  showUpdateTime: boolean
 }): string => {
   const imageUrl = `https://lapras-card-generator.vercel.app/api/svg?e=${
     score.eScore
@@ -24,7 +24,7 @@ const createCardText = ({
     theme.icon.first
   )}&i2=${encodeURIComponent(theme.icon.second)}&l=${lang}`
 
-  const updateTime = hideUpdateTime ? '' : `  \nLast Updated on ${new Date().toLocaleString()}`
+  const updateTime = showUpdateTime ? `  \nLast Updated on ${new Date().toLocaleString()}` : ''
 
   return `<a href="https://lapras.com/public/${shareId}" target="_blank" rel="noopener noreferrer"><img src="${imageUrl}" width="${cardWidth}" ></a>${updateTime}}`
 }
@@ -37,17 +37,17 @@ export const rewriteReadmeToIncludeCardText = (
     theme,
     lang,
     cardWidth,
-    hideUpdateTime,
+    showUpdateTime,
   }: {
     shareId: string
     score: Score
     theme: Theme
     lang: Language
     cardWidth: string
-    hideUpdateTime: boolean
+    showUpdateTime: boolean
   }
 ): string => {
   const re = new RegExp(`(${MARK.START})[\\s\\S]*(${MARK.END})`)
-  const cardText = createCardText({shareId, score, theme, lang, cardWidth, hideUpdateTime})
+  const cardText = createCardText({shareId, score, theme, lang, cardWidth, showUpdateTime})
   return readme.replace(re, `$1\n${cardText}\n$2`)
 }
diff --git a/src/main.ts b/src/main.ts
@@ -21,7 +21,7 @@ async function run(): Promise<void> {
     const lang = core.getInput('LANG') as Language
     const cardWidth = core.getInput('CARD_WIDTH')
     const token = core.getInput('GH_TOKEN')
-    const hideUpdateTime = core.getInput('HIDE_UPDATE_TIME') === 'true'
+    const showUpdateTime = core.getInput('UPDATE_TIME') === 'true'
 
     const readmeContent = await fetchPrevReadmeContent(token)
     const score = await fetchScore(shareId)
@@ -32,7 +32,7 @@ async function run(): Promise<void> {
       theme,
       lang,
       cardWidth,
-      hideUpdateTime
+      showUpdateTime
     })
 
     await updateReadme({ghToken: token, readme, sha: readmeContent.sha})