Fix a memory leak during fsm_determinise_with_config's early exit
#504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edge sets leak when halting with FSM_DETERMINISE_WITH_CONFIG_STATE_LIMIT_REACHED.
I verified that LeakSanitizer catches the leak during this test when the fix is reverted. This commit adds a test directory, `tests/regressions`, for misc. regression tests that need a .c file and aren't easily testable via fsm, re, etc. inputs.
silentbicycle
commented
Nov 8, 2024
| #include <fsm/fsm.h> | ||
| #include <fsm/bool.h> | ||
|
|
||
| static const char *strings[] = { |
There was a problem hiding this comment.
The input here is arbitrary, but one easy way to make a FSM whose state count increases significantly during determinisation is to combine several unanchored patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/regressionsdirectory for test cases that need a standalone C file, because they aren't easily reproducible via fsm, re, etc. input files.fsm_determinise_with_config's early exit due to the state limit. When run with LeakSanitizer or Valgrind and with the previous commit reverted, it will show that the edge sets for the DFA being constructed weren't freed properly.