Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small bugfixes #490

Merged
merged 8 commits into from
Aug 26, 2024
Merged

A few small bugfixes #490

merged 8 commits into from
Aug 26, 2024

Commits on Aug 24, 2024

  1. Wrong exit status for -G.

    Spotted by @pierreganty (#478), thank you
    katef committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    84f3835 View commit details
    Browse the repository at this point in the history
  2. Wrong return type for AMBIG_ERROR/AMBIG_EARLIEST.

    Spotted by @sw17ch, thank you.
    katef committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    60baaab View commit details
    Browse the repository at this point in the history
  3. -C opt-level=3 makes a huge difference here.

    Spotted by @sw17ch, thank you.
    katef committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    e7a21b4 View commit details
    Browse the repository at this point in the history
  4. Missing language.

    katef committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    edeb291 View commit details
    Browse the repository at this point in the history
  5. Off by one.

    Previously this gave:
    ```
    ; ./build/bin/re -r literal -G 3 abc
    ; ./build/bin/re -r literal -G 4 abc
    abc
    ;
    ```
    and now -G 3 does construct "abc" (not including the newline, which is a property of the printing, not of the constructed string):
    ```
    ; ./build/bin/re -r literal -G 3 abc
    abc
    ; ./build/bin/re -r literal -G 4 abc
    abc
    ;
    ```
    
    and:
    ```
    ; ./build/bin/re -r native -G 3 '^x+$'
    x
    xx
    xxx
    ```
    
    Spotted by @pierreganty (#478), thank you
    katef committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    3769f77 View commit details
    Browse the repository at this point in the history
  6. Bump actions for Node 20.

    katef committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    00ad53b View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Stray assertion.

    This doesn't help for #317, but whatever the solution is there, asserting about it is the wrong thing to do.
    
    Spotted by @classabbyamp, thank you
    katef committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    5010a40 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Update for hooks & options API changes.

    I have extremely broken the iprange example. I am very unsure what's going on with this program.
    katef committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ebbcb35 View commit details
    Browse the repository at this point in the history