This repository has been archived by the owner on May 12, 2021. It is now read-only.
CI: Enable checkcommits #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jodh-intel , so we should open an issue before submitting a PR, wow about |
|
@liangchenye - currently, yes, you need an issue for all PRs. It's only a few clicks to create an issue and the idea is that you create the issue and get it assigned to yourself as soon as you start working on a change. That way, it's clear what is being worked on and by whom. This is important to keep track of "upcoming" features/fixes but also helps to avoid multiple people raising PRs for the same fix/feature. That scenario has actually happened more than once in Clear Containers! 😄 |
|
@jodh-intel thanks, I'll open an issue and submit again. |
jodh-intel
force-pushed
the
ci-add-checkcommits
branch
from
f77f67e
to
3b5751b
Compare
|
Hi @jcvenegas - could you review please? |
|
lgtm |
|
Can you please rebase to pass CI now that #40 is merged? |
Require all PRs to contain a "Fixes #XXX" comment and a "Signed-off-by:" comment by running the central static checks script. Note that the static checks script will detect if the repository contains golang code and only run those checks if it does. Fixes kata-containers#12. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
force-pushed
the
ci-add-checkcommits
branch
from
3b5751b
to
895aad1
Compare
|
Branch updated. |
|
lgtm |
Pennyzct
added a commit
to Pennyzct/osbuilder
that referenced
this pull request
Jun 24, 2019
For euleros, it has supported aarch64 starting from v2.3, but here is the sad part, there existed bugs in their 2.3.x image, this bug existed in both x86_64 and aarch64 image. related issue euleros/euleros-docker-images/kata-containers#13 (euleros/euleros-docker-images#13) has been raised. Fixes: kata-containers#320 Signed-off-by: Penny Zheng <[email protected]>
Pennyzct
added a commit
to Pennyzct/osbuilder
that referenced
this pull request
Jun 24, 2019
For euleros, it has supported aarch64 starting from v2.3, but here is the sad part, there existed bugs in their 2.3.x image, this bug existed in both x86_64 and aarch64 image. related issue euleros/euleros-docker-images/kata-containers#13 (euleros/euleros-docker-images#13) has been raised. Fixes: kata-containers#320 Signed-off-by: Penny Zheng <[email protected]>
marcov
pushed a commit
to marcov/kata-osbuilder
that referenced
this pull request
Jul 17, 2019
For euleros, it has supported aarch64 starting from v2.3, but here is the sad part, there existed bugs in their 2.3.x image, this bug existed in both x86_64 and aarch64 image. related issue euleros/euleros-docker-images/kata-containers#13 (euleros/euleros-docker-images#13) has been raised. Fixes: kata-containers#320 Signed-off-by: Penny Zheng <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require all PRs to contain a "Fixes #XXX" comment and a
"Signed-off-by:" comment.
Also necessitated adding a very minimal
.travis.ymltotrigger
checkcommits.Fixes #12.
Signed-off-by: James O. D. Hunt [email protected]