fix: revert deletion of tests auto-run after pull_request changes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugITwhisperer
changed the title
bugITwhisperer
requested review from
kat-kan,
KarolinaZakrzewska and
adamcegielka
|
It's not visible in PR #63 yet somehow most of the tests are currently skipped on the main branch. Is it something that is necessary? |
kat-kan
previously approved these changes
Jan 20, 2024
adamcegielka
previously approved these changes
Jan 22, 2024
bugITwhisperer
dismissed stale reviews from adamcegielka and kat-kan
via
de7ca66
|
@kat-kan : they should not be skipped - I've just removed the |
|
@kat-kan , @adamcegielka , @KarolinaZakrzewska , @Justyna-KO : could you please review the changes? Also, please note that I marked 2 tests as fixme from the
|
Justyna-KO
previously approved these changes
Feb 4, 2024
adamcegielka
previously approved these changes
Feb 5, 2024
bugITwhisperer
dismissed stale reviews from adamcegielka and Justyna-KO
via
a152404
bugITwhisperer
requested review from
Justyna-KO
and removed request for
KarolinaZakrzewska
# Conflicts: # .github/workflows/pw-tests.yml # tests/api/articles/articles-post.spec.ts
|
@Justyna-KO @Slawomir-DKl I updated this branch and PR description, the history of branch is overwhelming but eventually the changes not so much :) please review! |
Slawomir-DKl
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19
Continuation of PR #63
which was merged by accident
Scope of changes
revert deletion of running on pr changes(must have been fixed in another PR, comment by @kat-kan).mdfiles are modified)PR steps completed:
kawqa-gad-playwrightproject's git commit message format