[Issue#25] add test API for DELETE by id for article #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcegielka
requested review from
kat-kan,
KarolinaZakrzewska and
bugITwhisperer
adamcegielka
changed the title
bugITwhisperer
changed the title
bugITwhisperer
requested changes
Nov 8, 2023
kat-kan
requested changes
Nov 8, 2023
|
I have added corrections in the test, the test works correctly, please review :) |
adamcegielka
changed the title
bugITwhisperer
requested changes
Nov 9, 2023
bugITwhisperer
requested changes
Nov 9, 2023
kat-kan
requested changes
Nov 14, 2023
tests/api/articles-id-delete.spec.ts
Outdated
| }); | ||
|
|
||
| test("delete article by ID 60", async ({ request }) => { | ||
| const nonExistentArticleID = 60; |
There was a problem hiding this comment.
I believe you meant the existing article?
…into chore/ISSUE-25_DELETE_articles_id-test
kat-kan
reviewed
Jan 2, 2024
tests/api/articles-id-delete.spec.ts
Outdated
| expect(deleteResponse.status()).toBe(expectedResponseCode); | ||
| }); | ||
|
|
||
| // Error - Received: 401 |
There was a problem hiding this comment.
I know that we discussed that but a lot of time passed by and I completely don't remember. Can you please explain again why this test fails?
There was a problem hiding this comment.
Agreed 5.02:
- reason it fails is because regular user can try to delete only his/her article
- would be nice to add 2 different tests, for regular user and admin
…into chore/ISSUE-25_DELETE_articles_id-test
bugITwhisperer
requested changes
Feb 5, 2024
| import { testUsers } from "@_src_fixtures_api/auth"; | ||
|
|
||
| test.describe("DELETE articles/{id}", () => { | ||
| const baseURL: string = process.env.BASE_URL; |
There was a problem hiding this comment.
as discussed this can be deleted
|
|
||
| test.describe("DELETE articles/{id}", () => { | ||
| const baseURL: string = process.env.BASE_URL; | ||
| const articles: string = `${baseURL}/api/articles/`; |
There was a problem hiding this comment.
baseURL part can be deleted
| }); | ||
|
|
||
| // 401 status received - Use the `test.fail();` instruction to mark as a failed test | ||
| test("returns 404 status code when delete a non-existent article", async ({ request }) => { |
There was a problem hiding this comment.
test to fix: returns 401 when delete a non-existing article as a regular user
|
|
||
| // Then: The response status code should be 404 | ||
| expect(response.status()).toBe(expectedResponseCode); | ||
| }); |
There was a problem hiding this comment.
new test to be added: returns 404 when delete a non-existing article as an admin user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft to verify the API request for POST and DELETE method