Refactor FunctionService from singleton to class #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddsund
requested review from
kcs85,
JegHeterGyda,
malinnsnieske and
halvparten
halvparten
approved these changes
Mar 11, 2025
|
digg |
kcs85
approved these changes
Mar 13, 2025
oddsund
force-pushed
the
functionservice-refactor
branch
2 times, most recently
from
dd3dc45 to
4b3057b
Compare
oddsund
force-pushed
the
functionservice-refactor
branch
from
4b3057b to
82e1935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beskrivelse
🥅 Mål med PRen: Løsne den harde koblingen mellom FunctionService og FunctionRoutes, samt gjøre koden lettere å teste uten biblioteker
Løsning
🆕 Endring: FunctionService er nå endret til en klasse som implementerer et interface. Ved å gjøre FunctionRoutes avhengig av interfacet, istedenfor klassen, kan vi enkelt mocke den for testene uten å måtte bruke biblioteker og FunctionRoutes har ikke lenger den harde knytningen til FunctionService implementasjonen.
Flyttet også dto'ene til egen mappe, slik at det er tydeligere hvor de ligger.
🧪 Testing
Er det noe spesielt den som reviewer PRen bør sjekke?
🔒 Sikkerhet / Trusselvurdering