Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add layer apis #11

Merged
merged 9 commits into from
Apr 6, 2024
Merged

add layer apis #11

merged 9 commits into from
Apr 6, 2024

Conversation

danangmassandy
Copy link
Collaborator

@danangmassandy danangmassandy commented Apr 5, 2024

This is for ConservationInternational/cplus-plugin#360.

  • Provide an API to upload layers by a user.
  • Provide an API to list existing uploaded layers.
  • Provide an API to delete existing uploaded layer.
  • Provide an API to fetch detail of single layer.

For other acceptance criteria in the ticket, I'll submit in new PR (might to create new tickets as well to track these items).

This is still work in progress with pending todos:

  • Add api tests
  • Add validations

Copy link

github-actions bot commented Apr 5, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1447 1343 93% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 650a0bb by action🐍

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 99.04535% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.80%. Comparing base (5ec3782) to head (650a0bb).

Files Patch % Lines
django_project/cplus_api/tests/common.py 94.11% 2 Missing ⚠️
django_project/cplus_api/utils/api_helper.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   89.63%   92.80%   +3.17%     
==========================================
  Files          43       51       +8     
  Lines        1032     1446     +414     
==========================================
+ Hits          925     1342     +417     
+ Misses        107      104       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danangmassandy danangmassandy marked this pull request as ready for review April 6, 2024 16:23
@danangmassandy danangmassandy merged commit 8e02f63 into main Apr 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant