Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase the timeout interval for fetching map config #209

Merged
merged 11 commits into from
Apr 18, 2024
9 changes: 8 additions & 1 deletion components/SearchEventsListener.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ const SearchEventsListener: FC = () => {
start_min: startMinParam,
start_max: startMaxParam,
end_min: endMinParam,
orgTag: orgTagParam,
} = query

const { slug } = query
Expand Down Expand Up @@ -84,7 +85,8 @@ const SearchEventsListener: FC = () => {
limit = limit !== 0 ? limit : undefined

const typeNames = getTypeNamesFromRouterOrKnownCategoryNamesIfEmpty(router)


const orgTag: string = convertQueryParamToString(orgTagParam)
const fixedTags: string[] = convertQueryParamToArray(fixedTagsParam)
const tags: string[] = convertQueryParamToArray(tagsParam)
const compoundTags = [...fixedTags, ...tags]
Expand All @@ -101,6 +103,11 @@ const SearchEventsListener: FC = () => {
categories: toString(entryCategories),
limit: limit,
}

if (orgTag !== '') {
searchEntriesRequestDTO.org_tag = orgTag
}

dispatch(fetchEntries(searchEntriesRequestDTO))
} else {
dispatch(emptyEntries())
Expand Down
31 changes: 17 additions & 14 deletions components/Sidebar.tsx
Original file line number Diff line number Diff line change
@@ -1,23 +1,27 @@
import {FC, useEffect, useState} from 'react'
import {FC, useEffect, useState, useMemo } from 'react'
import dynamic from 'next/dynamic'
import {useRouter} from 'next/router'
import {Drawer} from 'antd'
import { LeftOutlined } from '@ant-design/icons'
import { Drawer } from 'antd'
import SidebarContent from './SidebarContent'
import SidebarCollapseButton from './SidebarCollapseButton'
import {convertQueryParamToString} from '../utils/utils'
import {isSidebarStatusShown} from '../dtos/SidebarStatus'
import {useSidebar} from '../hooks/useResponsive'
import { closeSidebar } from './SidebarCollapseButton'



interface SidebarProps {
title: String
}


const Sidebar: FC<SidebarProps> = (props) => {
const { title } = props

const ClientDrawer = useMemo(() => dynamic(
() => Promise.resolve(Drawer),
{
ssr: false,
},
), [])

const router = useRouter()
const {
Expand All @@ -37,10 +41,11 @@ const Sidebar: FC<SidebarProps> = (props) => {
}, [shouldOpenSidebar])

return (
<Drawer
<ClientDrawer
autoFocus={false}
closable={false}
forceRender
open={isSidebarOpen}
closeIcon={<LeftOutlined/>}
placement="left"
mask={false}
rootStyle={{
Expand All @@ -49,25 +54,23 @@ const Sidebar: FC<SidebarProps> = (props) => {
display: 'flex',
overflowX: 'clip',
overflowY: 'scroll',
position: 'absolute',
}}
getContainer={false}
width={isSidebarOpen ? sidebarWidth : 0}
styles={{
body: {
padding: 0
},
header: {
padding: 6,
wrapper: {
display: 'block'
}
}}
title={title}
onClose={() => closeSidebar(router)}
>
<SidebarCollapseButton />
{isSidebarOpen && (
<SidebarContent/>
)}
</Drawer>
</ClientDrawer>
)
}

Expand Down
27 changes: 21 additions & 6 deletions components/SidebarCollapseButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,23 +76,33 @@ const SidebarCollapseButtonIcon: FC<CollapseSidebarButtonIcon> = (props) => {
return <FontAwesomeIcon icon='chevron-left' />
}

const SidebarCollapseButton: FC = () => {
interface SidebarCollapseButtonProps {
isOnMap?: boolean
}

const SidebarCollapseButton: FC<SidebarCollapseButtonProps> = (props) => {
const {isOnMap} = props

const router = useRouter()
const { query } = router
const { sidebar: sidebarParam } = query
const isSidebarOpen = isSidebarStatusShown(convertQueryParamToString(sidebarParam))

return (
<Button
icon={
<SidebarCollapseButtonIcon showOpenIcon />
<SidebarCollapseButtonIcon showOpenIcon={!isSidebarOpen} />
}
onClick={toggleSidebarState(router, false)}
onClick={toggleSidebarState(router, isSidebarOpen)}
size='middle'
style={{
height: 68,
width: 36,
position: 'fixed',
position: 'absolute',
top: 52,
left: 0,
zIndex: 500,
transform: 'translateX(100%)',
right: 0,
zIndex: 400,
visibility: 'visible',
display: 'block'
}}
Expand All @@ -101,4 +111,9 @@ const SidebarCollapseButton: FC = () => {
}


SidebarCollapseButton.defaultProps = {
isOnMap: false
}


export default SidebarCollapseButton
3 changes: 2 additions & 1 deletion locales/en/map.json
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,8 @@
"loginForPilots": "Login",
"contact": "Contact",
"aboutUs": "About",
"privacy": "Privacy"
"privacy": "Privacy",
"UnsubscribeMailnotification": "Unsubscirbe Mailnotification"
},
"mapColorMode": {
"colorful": "Colorful",
Expand Down
3 changes: 2 additions & 1 deletion locales/fr/map.json
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,8 @@
"loginForPilots": "Login",
"contact": "Contact",
"aboutUs": "About",
"privacy": "Privacy"
"privacy": "Privacy",
"UnsubscribeMailnotification": "Unsubscirbe Mailnotification"
},
"mapColorMode": {
"colorful": "Colorée",
Expand Down
3 changes: 2 additions & 1 deletion locales/it/map.json
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,8 @@
"loginForPilots": "Login",
"contact": "Contact",
"aboutUs": "About",
"privacy": "Privacy"
"privacy": "Privacy",
"UnsubscribeMailnotification": "Unsubscirbe Mailnotification"
},
"mapColorMode": {
"colorful": "Colorful",
Expand Down
3 changes: 2 additions & 1 deletion locales/nl/map.json
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,8 @@
"loginForPilots": "Login",
"contact": "Contact",
"aboutUs": "About",
"privacy": "Privacy"
"privacy": "Privacy",
"UnsubscribeMailnotification": "Unsubscirbe Mailnotification"
},
"mapColorMode": {
"colorful": "Colorful",
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@types/react-copy-to-clipboard": "^5.0.4",
"@types/react-dom": "^18.0.10",
"@types/valid-url": "^1.0.4",
"antd": "^5.12.2",
"antd": "^5.14.0",
"autoprefixer": "^10.4.16",
"cross-env": "^7.0.3",
"eslint": "^8.30.0",
Expand Down Expand Up @@ -70,6 +70,7 @@
"opening_hours": "^3.8.0",
"qs": "^6.11.2",
"rc-drawer": "^6.5.2",
"rc-picker": "^4.0.0-alpha.43",
"react-copy-to-clipboard": "^5.1.0",
"react-leaflet": "^4.2.1",
"react-lowlight": "^3.0.0",
Expand Down
3 changes: 3 additions & 0 deletions pages/m/[...slug].tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ export const getServerSideProps: GetServerSideProps = async (ctx) => {
// set configs
const pageConfigsReq = await AxiosInstance.GetRequest<MapPageConfigs>(
API_ENDPOINTS.getMapPageConfigs(project),
{
timeout: 120000,
}
)

const pageConfigs = AxiosInstance.GetSuccessData(pageConfigsReq)
Expand Down
Loading
Loading