fix: fedex_ws requests with invalid encodings

karrioapi · Sep 29, 2024 · ba8bc61 · ba8bc61
1 parent d48b65b
commit ba8bc61
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/modules/connectors/fedex_ws/karrio/providers/fedex_ws/pickup/availability.py b/modules/connectors/fedex_ws/karrio/providers/fedex_ws/pickup/availability.py
@@ -74,5 +74,5 @@ def _request_serializer(request: PickupAvailabilityRequest) -> str:
 
     return XP.export(
         envelope,
-        namespacedef_='xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22"',
+        namespacedef_='xmlns:tns="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22"',
     )
diff --git a/modules/connectors/fedex_ws/karrio/providers/fedex_ws/pickup/cancel.py b/modules/connectors/fedex_ws/karrio/providers/fedex_ws/pickup/cancel.py
@@ -79,5 +79,5 @@ def _request_serializer(request: CancelPickupRequest) -> str:
 
     return XP.export(
         envelope,
-        namespacedef_='xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22"',
+        namespacedef_='xmlns:tns="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22"',
     )
diff --git a/modules/connectors/fedex_ws/karrio/providers/fedex_ws/pickup/create.py b/modules/connectors/fedex_ws/karrio/providers/fedex_ws/pickup/create.py
@@ -159,7 +159,7 @@ def _request_serializer(request: CreatePickupRequest) -> str:
 
     return XP.export(
         envelope,
-        namespacedef_='xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22"',
+        namespacedef_='xmlns:tns="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22"',
     )
 
 

diff --git a/modules/connectors/fedex_ws/tests/fedex_ws/test_pickup.py b/modules/connectors/fedex_ws/tests/fedex_ws/test_pickup.py
@@ -162,7 +162,7 @@ def test_parse_pickup_cancel_reply(self):
 ]
 
 
-PickupAvailabilityRequestXML = """<tns:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22">
+PickupAvailabilityRequestXML = """<tns:Envelope xmlns:tns="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22">
     <tns:Body>
         <v22:PickupAvailabilityRequest>
             <v22:WebAuthenticationDetail>
@@ -206,7 +206,7 @@ def test_parse_pickup_cancel_reply(self):
 </tns:Envelope>
 """
 
-PickupRequestXML = """<tns:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22">
+PickupRequestXML = """<tns:Envelope xmlns:tns="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22">
     <tns:Body>
         <v22:CreatePickupRequest>
             <v22:WebAuthenticationDetail>
@@ -261,7 +261,7 @@ def test_parse_pickup_cancel_reply(self):
 </tns:Envelope>
 """
 
-PickupUpdateAvailabilityRequestXML = """<tns:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22">
+PickupUpdateAvailabilityRequestXML = """<tns:Envelope xmlns:tns="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22">
     <tns:Body>
         <v22:PickupAvailabilityRequest>
             <v22:WebAuthenticationDetail>
@@ -300,7 +300,7 @@ def test_parse_pickup_cancel_reply(self):
 </tns:Envelope>
 """
 
-PickupUpdateRequestXML = """<tns:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22">
+PickupUpdateRequestXML = """<tns:Envelope xmlns:tns="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22">
     <tns:Body>
         <v22:CreatePickupRequest>
             <v22:WebAuthenticationDetail>
@@ -353,7 +353,7 @@ def test_parse_pickup_cancel_reply(self):
 </tns:Envelope>
 """
 
-PickupCancelRequestXML = """<tns:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22">
+PickupCancelRequestXML = """<tns:Envelope xmlns:tns="http://schemas.xmlsoap.org/soap/envelope/" xmlns:v22="http://fedex.com/ws/pickup/v22">
     <tns:Body>
         <v22:CancelPickupRequest>
             <v22:WebAuthenticationDetail>