New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix allocation of scaling factors #459

Open

moritztng wants to merge 1 commit into karpathy:master from moritztng:fix-scaling-factors-allocation

moritztng commented Dec 9, 2023

allocate only one scaling factor per group


          fix allocation of scaling factors

b3317b9

Owner

karpathy commented Feb 13, 2024

huh. i'm only doing a quick skim atm. did i mess up the sizing of this oops

Author

moritztng commented Feb 13, 2024

you allocate dim elements for the quants and also dim elements for the scaling factors. but there are only dim / gs scaling factors :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet