Checking type of image first

karolzak · Nov 30, 2020 · a03fb2e · a03fb2e
1 parent 337bb99
commit a03fb2e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ipyplot/_html_helpers.py b/ipyplot/_html_helpers.py
@@ -274,7 +274,7 @@ def _create_img(
         img_html += '<h4 style="font-size: 12px; word-wrap: break-word;">%s</h4>' % str(custom_text)  # NOQA E501
 
     use_b64 = True
-    inline_svg = (inline_svg and image[-4:]==".svg")
+    inline_svg = (inline_svg and isinstance(img,str) and image[-4:]==".svg")
     if inline_svg:
         use_b64 = False
     # if image is a string (URL) display its URL
@@ -293,8 +293,8 @@ def _create_img(
         img_html += '<img src="data:image/png;base64,%s"/>' % _img_to_base64(image, width)  # NOQA E501
 
     if inline_svg:
-        string = urllib.parse.quote(open(image,'r').read())
-        img_html += f'<img src="data:image/svg+xml,{string:s}">'
+        svg_url = urllib.parse.quote(open(image,'r').read())
+        img_html += f'<img src="data:image/svg+xml,{svg_url:s}">'
 
     html = """
     <div class="ipyplot-placeholder-div-%(0)s">