Skip to content
This repository has been archived by the owner on Jun 30, 2018. It is now read-only.

Correct debug log level is 'debug' #935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryansch
Copy link
Contributor

@ryansch ryansch commented Feb 5, 2014

The project README suggests setting up debug logging with the following:

 Tire.configure { logger 'elasticsearch.log', :level => 'debug' }

This pull fixes the Index#bulk debug output to test for the 'debug' log level instead of 'verbose'.

@karmi
Copy link
Owner

karmi commented Feb 5, 2014

@ryansch That was deliberate, as far as I remember... Otherwise you'd see lines and lines of curl commands.

On the other hand, I can see how debug would print the "data omitted" version, and the verbose version would print the JSON docs being sent over the wire...

@karmi karmi added the reminder label Feb 5, 2014
@ryansch
Copy link
Contributor Author

ryansch commented Feb 5, 2014

I suppose the problem is setting the log level to verbose means I lose all of the other debug logging.

@karmi
Copy link
Owner

karmi commented Feb 6, 2014

Agreed... I don't think we can "fix" Tire in this respect, though... I would keep this bug freezed, to be honest, to not change the behaviour on the re-tired project...

@ryansch
Copy link
Contributor Author

ryansch commented Feb 10, 2014

Works for me. We're already using the new elasticsearch gem and slowly letting it take over our project. 😄

@karmi
Copy link
Owner

karmi commented Feb 10, 2014

Very glad to hear that :) Let's let this sleep then -- otehrwise, if it would really help you with something, we can make the change.

@karmi karmi added bug and removed reminder labels Apr 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants