Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go version and karmada version in go.mod #17

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Upgrade go version and karmada version in go.mod #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions cmd/controller-manager/controller-manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
package main

import (
"math/rand"
"os"
"time"

"k8s.io/component-base/cli"
cliflag "k8s.io/component-base/cli/flag"
Expand All @@ -19,8 +17,6 @@ import (
)

func main() {
rand.Seed(time.Now().UnixNano())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seed function is marked as deprecated, but the CI checks the function. As a result, the CI fails to run.

For details about why a seed is marked as obsolete, see golang/go#56319.

The other reason is that we don't currently use rand in our repository.

For the above two reasons, I removed this line.


ctx := controllerruntime.SetupSignalHandler()
opts := options.NewClusterControllerManagerOptions()
fss := cliflag.NamedFlagSets{}
Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module github.com/karmada-io/multicluster-cloud-provider

go 1.19
go 1.20

require (
github.com/karmada-io/karmada v1.9.0-preview5.0.20240227142131-bc9316705c36
github.com/karmada-io/karmada v1.9.0
github.com/pkg/errors v0.9.1
github.com/spf13/cobra v1.7.0
github.com/spf13/pflag v1.0.5
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,8 @@ github.com/json-iterator/go v1.1.12 h1:PV8peI4a0ysnczrg+LtxykD8LfKY9ML6u2jnxaEnr
github.com/json-iterator/go v1.1.12/go.mod h1:e30LSqwooZae/UwlEbR2852Gd8hjQvJoHmT4TnhNGBo=
github.com/jstemmer/go-junit-report v0.0.0-20190106144839-af01ea7f8024/go.mod h1:6v2b51hI/fHJwM22ozAgKL4VKDeJcHhJFhtBdhmNjmU=
github.com/julienschmidt/httprouter v1.2.0/go.mod h1:SYymIcj16QtmaHHD7aYtjjsJG7VTCxuUUipMqKk8s4w=
github.com/karmada-io/karmada v1.9.0-preview5.0.20240227142131-bc9316705c36 h1:ROH0MFo+/6LLp/QqJz3ePuAhvzjfFgBoPs0e/HM+DPc=
github.com/karmada-io/karmada v1.9.0-preview5.0.20240227142131-bc9316705c36/go.mod h1:oags1hCX1XzogohgXRPV4sLXB+RW6MCXBN8+ny0HfMk=
github.com/karmada-io/karmada v1.9.0 h1:Xr2GQEdZBIgDRBrdiArCFehLFJw1KtU/iB394SP8cl0=
github.com/karmada-io/karmada v1.9.0/go.mod h1:568vm0Rcn9MJaKhajDiFPDQ4Y9LxrfVjzEOek9UdFLg=
github.com/kisielk/errcheck v1.1.0/go.mod h1:EZBBE59ingxPouuu3KfxchcWSUPOHkagtvWXihfKN4Q=
github.com/kisielk/errcheck v1.2.0/go.mod h1:/BMXB+zMLi60iA8Vv6Ksmxu/1UDYcXs4uQLJ+jE2L00=
github.com/kisielk/errcheck v1.5.0/go.mod h1:pFxgyoBC7bSaBwPgfKdkLd5X25qrDl4LWUI2bnpBCr8=
Expand Down
Loading