Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiclusteringress service locations controller #14

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Feb 27, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add multiclusteringress service locations controller to maintain information about the clusters in which the Service backend of the MultiClusterIngress resource resides.

Please refer to the proposal in the karmada repo: karmada-io/karmada#4651

Which issue(s) this PR fixes:
Part of karmada-io/karmada#4658

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add multiclusteringress service locations controller

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 27, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 27, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-mci-services-backends-controller branch 6 times, most recently from bc68e2f to 9f1826d Compare February 27, 2024 16:19
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2024
@XiShanYongYe-Chang
Copy link
Member Author

It relies on #15
/hold

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-mci-services-backends-controller branch 2 times, most recently from 1492074 to 417f98a Compare February 28, 2024 02:18
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 28, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-mci-services-backends-controller branch from 417f98a to 171962b Compare February 28, 2024 06:56
@XiShanYongYe-Chang
Copy link
Member Author

/hold cancel
/cc @RainbowMango

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@karmada-bot karmada-bot merged commit ba04910 into karmada-io:main Feb 28, 2024
4 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the add-mci-services-backends-controller branch February 28, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants