fix: failed to sync work when binding's target clusters are empty #5818
+50
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
For now, when binding is not scheduled, which means clusters field is empty, work will still be synced. And this log will be printed.
Sync work of resourceBinding(%s/%s) successful
But actually no work is created. I think it's necessary to check whether clusters field of binding is empty. I'not sure this should be added to predicates of controller or just put it into syncbinding function, like my current pr code. I think the latter is better, in this way, users can see scheduling encounter some problems.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: