Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/karmadactl/addons/init: unit test enable and disable addon operations #5771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we unit test enable and disable addon operations that are utilized across all addons. The test cases include the general validation on passed inputs and expected outputs in addition to running the actual op enable/disable.

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

In this commit, we unit test enable and disable addon operations
that are utilized across all addons. The test cases include the general
validation on passed inputs and expected outputs in addition to running
the actual op enable/disable.

Signed-off-by: Mohamed Awnallah <[email protected]>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wuyingjun-lucky for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 1, 2024
@mohamedawnallah mohamedawnallah changed the title pkg/karmadactl: unit test enable and disable ops pkg/karmadactl: unit test enable and disable addon operations Nov 1, 2024
@mohamedawnallah mohamedawnallah changed the title pkg/karmadactl: unit test enable and disable addon operations pkg/karmadactl/addons/init: unit test enable and disable addon operations Nov 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 42.44%. Comparing base (057cf86) to head (cb2f99b).

Files with missing lines Patch % Lines
pkg/karmadactl/addons/init/enable_option.go 46.15% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5771      +/-   ##
==========================================
+ Coverage   42.31%   42.44%   +0.13%     
==========================================
  Files         655      655              
  Lines       55756    55761       +5     
==========================================
+ Hits        23591    23667      +76     
+ Misses      30651    30572      -79     
- Partials     1514     1522       +8     
Flag Coverage Δ
unittests 42.44% <53.33%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants