-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Karmada installed by operator to use karmadactl register #5755
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0843bc9
to
10cd319
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5755 +/- ##
==========================================
+ Coverage 42.25% 42.31% +0.06%
==========================================
Files 655 655
Lines 55756 55756
==========================================
+ Hits 23561 23595 +34
+ Misses 30683 30649 -34
Partials 1512 1512
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Due to the lack of permissions in CI to create directories |
Signed-off-by: zhzhuang-zju <[email protected]>
10cd319
to
84b6770
Compare
local Verification: $ hack/local-up-karmada-by-operator.sh
$ hack/create-cluster.sh member4 ~/.kube/member4.config
$ eval $(karmadactl token create --print-register-command --kubeconfig ~/.kube/karmada.config --karmada-context karmada-apiserver) --kubeconfig ~/.kube/member4.config --karmada-agent-image docker.io/karmada/karmada-agent:latest
[preflight] Running pre-flight checks
[preflight] All pre-flight checks were passed
[karmada-agent-start] Waiting to perform the TLS Bootstrap
[karmada-agent-start] Waiting to construct karmada-agent kubeconfig
[karmada-agent-start] Waiting to check cluster exists
[karmada-agent-start] Waiting the necessary secret and RBAC
[karmada-agent-start] Waiting karmada-agent Deployment
cluster(kind-member4) is joined successfully
|
/hold |
good point! Incorporating RBAC configurations into the workflow of the karmada-operator is more reasonable |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Karmadactl register
is a command provided by Karmada to register pull mode clusters to the Karmada control plane. Currently, when Karmada is installed via the karmada-operator, there are functional issues when executingkarmadactl register
.The purpose of this PR is to support Karmada installations by the operator to use
karmadactl register
. The changes include:Due to the credentials used by the karmada-agent being in the
system:nodes
group, with a username in the formsystem:node:
, its permissions are restricted.karmadactl register
command to register a pull mode member cluster.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: