Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix operator file naming #5740

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

husnialhamdani
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
Fix typo in operator file name

Which issue(s) this PR fixes:
Fixes #5658

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot
Copy link
Collaborator

Welcome @husnialhamdani! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target file name should be manifests.go. What we are going to fix is the typo, not removing the suffix.

PS: I'm sorry I missed .go in the previous issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.66%. Comparing base (7347f11) to head (655aa55).
Report is 21 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5740      +/-   ##
==========================================
+ Coverage   40.86%   41.66%   +0.80%     
==========================================
  Files         651      653       +2     
  Lines       55259    55518     +259     
==========================================
+ Hits        22582    23132     +550     
+ Misses      31237    30885     -352     
- Partials     1440     1501      +61     
Flag Coverage Δ
unittests 41.66% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

Hi @husnialhamdani Thanks for the quick response.
You might need to

  1. Sign the DCO according to the guideline to make CI happy.
  2. Squash the commits according to the guideline.

Then we are ready to move forward.

@husnialhamdani
Copy link
Contributor Author

husnialhamdani commented Oct 25, 2024

Hi @husnialhamdani Thanks for the quick response. You might need to

  1. Sign the DCO according to the guideline to make CI happy.
  2. Squash the commits according to the guideline.

Then we are ready to move forward.

Hi @RainbowMango,
Could you please check now?

@RainbowMango
Copy link
Member

This PR now contains a commit that it shouldn't have.

Signed-off-by: Husni Alhamdani <[email protected]>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @husnialhamdani I helped to squash the commits as I see you might have some trouble with it.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@karmada-bot karmada-bot merged commit ff6075c into karmada-io:master Oct 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typo in operator file name
4 participants