-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix operator file naming #5740
fix operator file naming #5740
Conversation
Welcome @husnialhamdani! It looks like this is your first PR to karmada-io/karmada 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The target file name should be manifests.go
. What we are going to fix is the typo, not removing the suffix.
PS: I'm sorry I missed .go
in the previous issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5740 +/- ##
==========================================
+ Coverage 40.86% 41.66% +0.80%
==========================================
Files 651 653 +2
Lines 55259 55518 +259
==========================================
+ Hits 22582 23132 +550
+ Misses 31237 30885 -352
- Partials 1440 1501 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @husnialhamdani Thanks for the quick response.
Then we are ready to move forward. |
07c29de
to
ccb55f4
Compare
Hi @RainbowMango, |
This PR now contains a commit that it shouldn't have. |
a628ab1
to
07c29de
Compare
07c29de
to
a5310e0
Compare
Signed-off-by: Husni Alhamdani <[email protected]>
a5310e0
to
655aa55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @husnialhamdani I helped to squash the commits as I see you might have some trouble with it.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Fix typo in operator file name
Which issue(s) this PR fixes:
Fixes #5658
Special notes for your reviewer:
Does this PR introduce a user-facing change?: