-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CA data to local up generated karmada config for enhanced security #5739
Conversation
Signed-off-by: chaosi-zju <[email protected]>
thanks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5739 +/- ##
==========================================
+ Coverage 40.63% 40.85% +0.21%
==========================================
Files 650 651 +1
Lines 55184 55256 +72
==========================================
+ Hits 22426 22574 +148
+ Misses 31321 31241 -80
- Partials 1437 1441 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhzhuang-zju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Execute
karmadactl token create
command failed, because the cluster is setinsecure-skip-tls-verify=true
in karmada config, that is a insecure config.So, this PR add CA data to local up generated karmada config for enhanced security.
Which issue(s) this PR fixes:
Fixes #5738
Special notes for your reviewer:
test report:
$ karmadactl token create --print-register-command --kubeconfig ~/.kube/karmada.config --karmada-context karmada-apiserver karmadactl register 172.18.0.4:5443 --token yqnbkt.muyyaah5omv1s24d --discovery-token-ca-cert-hash sha256:4f12a0f772cdaecfb7e150992f627485485d75922ddae5080bcb50a79bf22971
Does this PR introduce a user-facing change?: