Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e for migration rollback feature #5609

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

wulemao
Copy link
Contributor

@wulemao wulemao commented Sep 26, 2024

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

add e2e for migration rollback feature

Which issue(s) this PR fixes:

Fixes part of #5577

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Sep 26, 2024
@wulemao wulemao changed the title Rollback e2e1 add e2e for migration rollback feature Sep 26, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 26, 2024
@wulemao
Copy link
Contributor Author

wulemao commented Sep 26, 2024

/hold waiting for #5597 be merged

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
@chaosi-zju
Copy link
Member

I prefer to change the file name seamless_migration_test.go to migration_and_rollback_test.go since it now contains not only migration feature

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.64%. Comparing base (f7d6da3) to head (90c70df).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5609      +/-   ##
==========================================
+ Coverage   41.37%   41.64%   +0.26%     
==========================================
  Files         651      653       +2     
  Lines       55265    55484     +219     
==========================================
+ Hits        22868    23107     +239     
+ Misses      30917    30878      -39     
- Partials     1480     1499      +19     
Flag Coverage Δ
unittests 41.64% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a7i
Copy link
Contributor

a7i commented Oct 17, 2024

@wulemao thanks for your patience, would you please rebase since the PR was merged?

@chaosi-zju
Copy link
Member

since #5717 merged, we can add a test case for Rollback the migration of dependency distributed resources.

@wulemao wulemao force-pushed the rollback-e2e1 branch 2 times, most recently from ce94f61 to 4b72a40 Compare October 24, 2024 03:48
@wulemao
Copy link
Contributor Author

wulemao commented Oct 24, 2024

/hold wait for #5731 and #5717 to be merged.

@chaosi-zju
Copy link
Member

/lgtm

cc @XiShanYongYe-Chang any more comments?

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@XiShanYongYe-Chang
Copy link
Member

/assign

@wulemao
Copy link
Contributor Author

wulemao commented Oct 26, 2024

done, any more comments?

@XiShanYongYe-Chang
Copy link
Member

Thanks
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2024
@chaosi-zju
Copy link
Member

chaosi-zju commented Oct 26, 2024

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2024
@chaosi-zju
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2024
@karmada-bot karmada-bot merged commit 53afbbc into karmada-io:master Oct 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants