-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add e2e for migration rollback feature #5609
Conversation
/hold waiting for #5597 be merged |
I prefer to change the file name |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5609 +/- ##
==========================================
+ Coverage 41.37% 41.64% +0.26%
==========================================
Files 651 653 +2
Lines 55265 55484 +219
==========================================
+ Hits 22868 23107 +239
+ Misses 30917 30878 -39
- Partials 1480 1499 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cebedf8
to
bf3f414
Compare
bf3f414
to
0133c2d
Compare
@wulemao thanks for your patience, would you please rebase since the PR was merged? |
0133c2d
to
1361cef
Compare
since #5717 merged, we can add a test case for |
ce94f61
to
4b72a40
Compare
4b72a40
to
f0a77f1
Compare
/lgtm cc @XiShanYongYe-Chang any more comments? |
f0a77f1
to
2d04d09
Compare
/assign |
2d04d09
to
575115d
Compare
Signed-off-by: wulemao <[email protected]>
575115d
to
90c70df
Compare
done, any more comments? |
Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/lgtm |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
add e2e for migration rollback feature
Which issue(s) this PR fixes:
Fixes part of #5577
Special notes for your reviewer:
Does this PR introduce a user-facing change?: