-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: introducing a scheduling strategy to customize cluster propagation priorities #5512
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5512 +/- ##
===========================================
+ Coverage 31.70% 43.18% +11.48%
===========================================
Files 643 656 +13
Lines 44445 55921 +11476
===========================================
+ Hits 14090 24149 +10059
- Misses 29325 30214 +889
- Partials 1030 1558 +528
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3d020fd
to
add8e03
Compare
docs/proposals/scheduling/aggregate-preference/aggregate-preference.md
Outdated
Show resolved
Hide resolved
add8e03
to
6921114
Compare
/retest |
+ // ReplicaDivisionPreferencePriorityAggregated assigns replicas to higher-priority clusters first, | ||
+ // then to lower-priority clusters if resources are insufficient. | ||
+ ReplicaDivisionPreferencePriorityAggregated ReplicaDivisionPreference = "PriorityAggregated" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ // ReplicaDivisionPreferencePriorityAggregated assigns replicas to higher-priority clusters first, | |
+ // then to lower-priority clusters if resources are insufficient. | |
+ ReplicaDivisionPreferencePriorityAggregated ReplicaDivisionPreference = "PriorityAggregated" | |
// ReplicaDivisionPreferencePriorityAggregated assigns replicas to higher-priority clusters first, | |
// then to lower-priority clusters if resources are insufficient. | |
ReplicaDivisionPreferencePriorityAggregated ReplicaDivisionPreference = "PriorityAggregated" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the PriorityAggregated
still honor the score plugins in the scheduler? In another world, what's the relationship of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sign "+" can reflect which lines are newly added. Does this need to be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the
PriorityAggregated
still honor the score plugins in the scheduler? In another world, what's the relationship of them?
I have updated the doc, this answer is in Controller logic changes
paragraph.
…agation priorities Signed-off-by: chaosi-zju <[email protected]>
6921114
to
368a6ae
Compare
What type of PR is this?
/kind feature
/kind design
What this PR does / why we need it:
This proposal introduces a new user scenario for scheduling, where users have preferences for clusters with
varying priorities and want replicas assigned to their preferred clusters.
To support this scenario, we propose two alternative solutions: one is adding
aggregatePreference
to the existingWeighted
replica scheduling strategy, and the other is enhancing the capability of multiple scheduling groups.Ultimately, we compare these two options and decide on the best implementation to provide a scheduling strategy
that allows users to customize cluster propagation priorities.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: